Bug 1726734 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Octal sequences of the style `0644` are deprecated in Javascript, and in strict mode are parsing errors.

We still have a few cases in dom/ and docshell/ that the [no-octal rule](https://eslint.org/docs/rules/no-octal) picks up.

Therefore we want to replace those. For example, `0644` can be replaced by `0o644`.

To enable the no-octal rules in these directories, remove the three lines in the top-level .eslintrc.js: https://searchfox.org/mozilla-central/rev/12770bd668c0a6bdaa8eb96ad9507c6febe8d23d/.eslintrc.js#288,373,448

ESLint can be run with: `./mach eslint dom docshell`.

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html

Note this bug will be auto-assigned when the first patch is attached.
Octal sequences of the style `0644` are deprecated in Javascript, and in strict mode are parsing errors.

We still have a few cases in dom/ that the [no-octal rule](https://eslint.org/docs/rules/no-octal) picks up.

Therefore we want to replace those. For example, `0644` can be replaced by `0o644`.

To enable the no-octal rules in these directories, remove the three lines in the top-level .eslintrc.js: https://searchfox.org/mozilla-central/rev/12770bd668c0a6bdaa8eb96ad9507c6febe8d23d/.eslintrc.js#288,373,448

ESLint can be run with: `./mach eslint dom`.

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html

Note this bug will be auto-assigned when the first patch is attached.

Back to Bug 1726734 Comment 0