1726734 - Enable ESLint no-octal rule on dom/

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P5)

Description

[Mark Banner (:standard8)]

Octal sequences of the style 0644 are deprecated in Javascript, and in strict mode are parsing errors.

We still have a few cases in dom/ that the no-octal rule picks up.

Therefore we want to replace those. For example, 0644 can be replaced by 0o644.

To enable the no-octal rules in these directories, remove the three lines in the top-level .eslintrc.js: https://searchfox.org/mozilla-central/rev/12770bd668c0a6bdaa8eb96ad9507c6febe8d23d/.eslintrc.js#288,373,448

ESLint can be run with: ./mach eslint dom.

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html

Note this bug will be auto-assigned when the first patch is attached.

Comment 1

[Mark Banner (:standard8)]

I just landed the docshell part in bug 1727591

Comment 2

[Tanmay]

Hey, can I work on the bug?

Comment 3

[Mark Banner (:standard8)]

Sure, no-one else has started yet, as I said in comment 0, this will be auto-assigned when the first patch is attached.

Comment 4

[Daniel Adams[:msub2]]

Attachment: Bug 1726734 - Replace deprecated octal sequences to satisfy ESLint no-octal-rule. r?standard8

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ed7cd12b366
Replace deprecated octal sequences to satisfy ESLint no-octal-rule. r=Standard8

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1ed7cd12b366