Bug 1731564 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
We introduced [`AutoNestedEventLoopAnnotation`](https://searchfox.org/mozilla-central/rev/13378066961f195595822d4f543c8ac5b7f46490/xpcom/threads/nsThreadManager.cpp#652) for JS `SpinEventLoop` usages.

We should extend this also to [normal C++ `SpinEventLoop` usages](https://searchfox.org/mozilla-central/search?q=symbol:_ZN7mozilla18SpinEventLoopUntilEOT0_P9nsIThread&redirect=false).

Furthermore we want to a `SpinEventLoopUntilOrShutdownPhase` variant for C++ usage, possibly with a parameter for the `ShutdownPhase` like [`nsThreadManager::SpinEventLoopUntilInternal`](https://searchfox.org/mozilla-central/rev/13378066961f195595822d4f543c8ac5b7f46490/xpcom/threads/nsThreadManager.cpp#691-694).
Revision 1 by
on 
We introduced [`AutoNestedEventLoopAnnotation`](https://searchfox.org/mozilla-central/rev/13378066961f195595822d4f543c8ac5b7f46490/xpcom/threads/nsThreadManager.cpp#652) for JS `SpinEventLoop` usages.

We should extend this also to [normal C++ `SpinEventLoop` usages](https://searchfox.org/mozilla-central/search?q=symbol:_ZN7mozilla18SpinEventLoopUntilEOT0_P9nsIThread&redirect=false).

Furthermore we want to have a `SpinEventLoopUntilOrShutdownPhase` variant for C++ usage, possibly with a parameter for the `ShutdownPhase` like [`nsThreadManager::SpinEventLoopUntilInternal`](https://searchfox.org/mozilla-central/rev/13378066961f195595822d4f543c8ac5b7f46490/xpcom/threads/nsThreadManager.cpp#691-694).
Revision 2 by
on 
We introduced [`AutoNestedEventLoopAnnotation`](https://searchfox.org/mozilla-central/rev/13378066961f195595822d4f543c8ac5b7f46490/xpcom/threads/nsThreadManager.cpp#652) for JS `SpinEventLoopUntil` usages.

We should extend this also to [normal C++ `SpinEventLoopUntil` usages](https://searchfox.org/mozilla-central/search?q=symbol:_ZN7mozilla18SpinEventLoopUntilEOT0_P9nsIThread&redirect=false).

Furthermore we want to have a `SpinEventLoopUntilOrShutdownPhase` variant for C++ usage, possibly with a parameter for the `ShutdownPhase` like [`nsThreadManager::SpinEventLoopUntilInternal`](https://searchfox.org/mozilla-central/rev/13378066961f195595822d4f543c8ac5b7f46490/xpcom/threads/nsThreadManager.cpp#691-694).

Back to Bug 1731564 Comment 0