1731564 - Have a mozilla:.SpinEventLoopUntil variant with AutoNestedEventLoopAnnotation

Status: RESOLVED FIXED

(Core :: XPCOM, task)

Description

[Jens Stutte [:jstutte]]

We introduced AutoNestedEventLoopAnnotation for JS SpinEventLoopUntil usages.

We should extend this also to normal C++ SpinEventLoopUntil usages.

Comment 1

[Jens Stutte [:jstutte]]

Attachment: Bug 1731564: Introduce a motivated SpinEventLoopUntil for direct use from C++. r?#xpcom-reviewers

This patch:

• renames the original SpinEventLoopUntil to BaseSpinEventLoopUntil
• changes all uses with IgnoreAndContinue behavior to BaseSpinEventLoopUntil
• moves the AutoNestedEventLoopAnnotation into SpinEventLoopUntil.h
• introduces MotivatedSpinEventLoopUntil
• maps remaining SpinEventLoopUntil instances to MotivatedSpinEventLoopUntil with "Missing motivation."

Comment 2

[Jens Stutte [:jstutte]]

Attachment: Bug 1731564: Use motivated SpinEventLoopUntil inside dom/*. r?smaug

Depends on D126714

Comment 3

[Jens Stutte [:jstutte]]

Attachment: Bug 1731564: Use motivated SpinEventLoopUntil inside devtools/*. r?#devtools-reviewers

Depends on D126957

Comment 4

[Jens Stutte [:jstutte]]

Attachment: Bug 1731564: Use motivated SpinEventLoopUntil inside gfx/*. r?#gfx-reviewers

Depends on D127099

Comment 5

[Jens Stutte [:jstutte]]

Attachment: Bug 1731564: Use motivated SpinEventLoopUntil inside ipc/*. r?#ipc-reviewers

Depends on D127100

Comment 6

[Jens Stutte [:jstutte]]

Attachment: Bug 1731564: Use motivated SpinEventLoopUntil inside netwerk/*. r?#necko-reviewers

Depends on D127102

Comment 7

[Jens Stutte [:jstutte]]

Attachment: Bug 1731564: Use motivated SpinEventLoopUntil inside extensions/*. r?#extension-reviewers

Depends on D127225

Comment 8

[Jens Stutte [:jstutte]]

Attachment: Bug 1731564: Use motivated SpinEventLoopUntil inside layout/*. r?#layout-reviewers

Depends on D127226

Comment 9

[Jens Stutte [:jstutte]]

Attachment: Bug 1731564: Use motivated SpinEventLoopUntil inside modules/*. r?#preferences-reviewers

Depends on D127230

Comment 10

[Jens Stutte [:jstutte]]

Attachment: Bug 1731564: Use motivated SpinEventLoopUntil inside security/*. r?bobowen

Depends on D127231

Comment 11

[Jens Stutte [:jstutte]]

Attachment: Bug 1731564: Use motivated SpinEventLoopUntil inside storage/*. r?janv

Depends on D127232

Comment 12

[Jens Stutte [:jstutte]]

Attachment: Bug 1731564: Use motivated SpinEventLoopUntil inside toolkit/*. r?Gijs

Depends on D127233

Comment 13

[Jens Stutte [:jstutte]]

Attachment: Bug 1731564: Use motivated SpinEventLoopUntil inside uriloader/*. r?smaug

Depends on D127234

Comment 14

[Jens Stutte [:jstutte]]

Attachment: Bug 1731564: Use motivated SpinEventLoopUntil inside widget/*. r?jmathies

Depends on D127235

Comment 15

[Jens Stutte [:jstutte]]

Attachment: Bug 1731564: Use motivated SpinEventLoopUntil inside xpcom/*. r?#xpcom-reviewers

Depends on D127236

Comment 16

[Jens Stutte [:jstutte]]

Attachment: Bug 1731564: Use motivated SpinEventLoopUntil inside xpfe/*. r?Neil

Depends on D127237

Comment 17

[Jens Stutte [:jstutte]]

Attachment: Bug 1731564: Remove the unmotivated SpinEventLoopUntil variant. r?#xpcom-reviewers

Depends on D127238

Comment 18

[Jens Stutte [:jstutte]]

Attachment: Bug 1731564: Add nested event loop stack to nsTerminator stderr output. r?#xpcom-reviewers

Depends on D127249

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/53e3f4862439
Introduce a motivated SpinEventLoopUntil for direct use from C++. r=xpcom-reviewers,nika,necko-reviewers
https://hg.mozilla.org/integration/autoland/rev/317bc38e3de5
Use motivated SpinEventLoopUntil inside dom/*. r=smaug
https://hg.mozilla.org/integration/autoland/rev/283c5393cbbc
Use motivated SpinEventLoopUntil inside devtools/*. r=devtools-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/d8071cc32bd9
Use motivated SpinEventLoopUntil inside gfx/*. r=gfx-reviewers,nical
https://hg.mozilla.org/integration/autoland/rev/874cab520ce5
Use motivated SpinEventLoopUntil inside ipc/*. r=ipc-reviewers,nika
https://hg.mozilla.org/integration/autoland/rev/e9d32926e93c
Use motivated SpinEventLoopUntil inside netwerk/*. r=necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/78d3b0257a6a
Use motivated SpinEventLoopUntil inside extensions/*. r=jesup
https://hg.mozilla.org/integration/autoland/rev/2cfb094a1ec3
Use motivated SpinEventLoopUntil inside layout/*. r=emilio
https://hg.mozilla.org/integration/autoland/rev/0d8905144f5d
Use motivated SpinEventLoopUntil inside modules/*. r=Gijs,KrisWright
https://hg.mozilla.org/integration/autoland/rev/bb8fb0f9833e
Use motivated SpinEventLoopUntil inside security/*. r=bobowen
https://hg.mozilla.org/integration/autoland/rev/73b648f1fa70
Use motivated SpinEventLoopUntil inside storage/*. r=janv
https://hg.mozilla.org/integration/autoland/rev/aa5ec3aa1535
Use motivated SpinEventLoopUntil inside toolkit/*. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/b0ce7db44b99
Use motivated SpinEventLoopUntil inside uriloader/*. r=smaug
https://hg.mozilla.org/integration/autoland/rev/d37700fa60b6
Use motivated SpinEventLoopUntil inside widget/*. r=smaug
https://hg.mozilla.org/integration/autoland/rev/37b41d187cdb
Use motivated SpinEventLoopUntil inside xpcom/*. r=xpcom-reviewers,nika
https://hg.mozilla.org/integration/autoland/rev/5630a0e7a109
Use motivated SpinEventLoopUntil inside xpfe/*. r=smaug
https://hg.mozilla.org/integration/autoland/rev/0d996df13545
Remove the unmotivated SpinEventLoopUntil variant. r=xpcom-reviewers,nika
https://hg.mozilla.org/integration/autoland/rev/0464dbdc8584
Add nested event loop stack to nsTerminator stderr output. r=xpcom-reviewers,nika

Comment 20

[Marian-Vasile Laza]

Backed out 18 changesets (Bug 1731564) for causing build bustages on SpinEventLoopUntil.
Backout link
Push with failures
Failure Log

Comment 21

[Jens Stutte [:jstutte]]

In the meantime we added another call to SpinEventLoopUntil (only active in fuzz builds). I launched a "build all" try push to see if I catched all of them now.

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea75553432cc
Introduce a motivated SpinEventLoopUntil for direct use from C++. r=xpcom-reviewers,nika,necko-reviewers
https://hg.mozilla.org/integration/autoland/rev/843fa018f79e
Use motivated SpinEventLoopUntil inside dom/*. r=smaug
https://hg.mozilla.org/integration/autoland/rev/9ecf86eb9ee4
Use motivated SpinEventLoopUntil inside devtools/*. r=devtools-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/208e47ee634d
Use motivated SpinEventLoopUntil inside gfx/*. r=gfx-reviewers,nical
https://hg.mozilla.org/integration/autoland/rev/da37d3f1fb85
Use motivated SpinEventLoopUntil inside ipc/*. r=ipc-reviewers,nika
https://hg.mozilla.org/integration/autoland/rev/9c56b5e39420
Use motivated SpinEventLoopUntil inside netwerk/*. r=necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/613a9c5d6bf5
Use motivated SpinEventLoopUntil inside extensions/*. r=jesup
https://hg.mozilla.org/integration/autoland/rev/64a63d1daad1
Use motivated SpinEventLoopUntil inside layout/*. r=emilio
https://hg.mozilla.org/integration/autoland/rev/88b4c6fc030f
Use motivated SpinEventLoopUntil inside modules/*. r=Gijs,KrisWright
https://hg.mozilla.org/integration/autoland/rev/4e25217a7807
Use motivated SpinEventLoopUntil inside security/*. r=bobowen
https://hg.mozilla.org/integration/autoland/rev/c8b58cc4c6a3
Use motivated SpinEventLoopUntil inside storage/*. r=janv
https://hg.mozilla.org/integration/autoland/rev/0cb449278fea
Use motivated SpinEventLoopUntil inside toolkit/*. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/390f30658f12
Use motivated SpinEventLoopUntil inside uriloader/*. r=smaug
https://hg.mozilla.org/integration/autoland/rev/71ed8555adc0
Use motivated SpinEventLoopUntil inside widget/*. r=smaug
https://hg.mozilla.org/integration/autoland/rev/d8c9be683fce
Use motivated SpinEventLoopUntil inside xpcom/*. r=xpcom-reviewers,nika
https://hg.mozilla.org/integration/autoland/rev/7b9f13fab8f0
Use motivated SpinEventLoopUntil inside xpfe/*. r=smaug
https://hg.mozilla.org/integration/autoland/rev/6263940a61d6
Remove the unmotivated SpinEventLoopUntil variant. r=xpcom-reviewers,nika
https://hg.mozilla.org/integration/autoland/rev/2d978650c932
Add nested event loop stack to nsTerminator stderr output. r=xpcom-reviewers,nika

Comment 23

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/ea75553432cc
https://hg.mozilla.org/mozilla-central/rev/843fa018f79e
https://hg.mozilla.org/mozilla-central/rev/9ecf86eb9ee4
https://hg.mozilla.org/mozilla-central/rev/208e47ee634d
https://hg.mozilla.org/mozilla-central/rev/da37d3f1fb85
https://hg.mozilla.org/mozilla-central/rev/9c56b5e39420
https://hg.mozilla.org/mozilla-central/rev/613a9c5d6bf5
https://hg.mozilla.org/mozilla-central/rev/64a63d1daad1
https://hg.mozilla.org/mozilla-central/rev/88b4c6fc030f
https://hg.mozilla.org/mozilla-central/rev/4e25217a7807
https://hg.mozilla.org/mozilla-central/rev/c8b58cc4c6a3
https://hg.mozilla.org/mozilla-central/rev/0cb449278fea
https://hg.mozilla.org/mozilla-central/rev/390f30658f12
https://hg.mozilla.org/mozilla-central/rev/71ed8555adc0
https://hg.mozilla.org/mozilla-central/rev/d8c9be683fce
https://hg.mozilla.org/mozilla-central/rev/7b9f13fab8f0
https://hg.mozilla.org/mozilla-central/rev/6263940a61d6
https://hg.mozilla.org/mozilla-central/rev/2d978650c932