Bug 1734428 Comment 22 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
(In reply to WaltS48 [:walts48] from comment #21)
> Error Console messages from 94.0b5:
> 
> 17:17:29.906 TypeError: requestor is null PdfStreamConverter.jsm:140:13
>     getDOMWindow resource://pdf.js/PdfStreamConverter.jsm:140
>     onStopRequest resource://pdf.js/PdfStreamConverter.jsm:1262
> 
> From 95.0a1, where the PDF wants to be saved:
> 
> 17:01:48.260 TypeError: can't access property "getInterface", requestor is null 3 PdfStreamConverter.jsm:140:13
>     getDOMWindow resource://pdf.js/PdfStreamConverter.jsm:140
>     onStopRequest resource://pdf.js/PdfStreamConverter.jsm:1262

This seems to be because the `attachment.contentType` is empty for *new* attachments instead of `application/pdf` when it is read here https://searchfox.org/comm-central/rev/7be97df3877fcaef928606b01d455b2b49d8e9ab/mail/components/compose/content/MsgComposeCommands.js#7610). After this, the error is the same as Bug 1698140.

Note that if a message is saved and reopened for editing, any saved pdf attachments will open fine, but any newly added attachments are missing their `contentType`. I think the missing `contentType` is probably a recent regression, since I didn't notice this when reviewing this patch.
Revision 1 by
on 
(In reply to WaltS48 [:walts48] from comment #21)
> Error Console messages from 94.0b5:
> 
> 17:17:29.906 TypeError: requestor is null PdfStreamConverter.jsm:140:13
>     getDOMWindow resource://pdf.js/PdfStreamConverter.jsm:140
>     onStopRequest resource://pdf.js/PdfStreamConverter.jsm:1262
> 
> From 95.0a1, where the PDF wants to be saved:
> 
> 17:01:48.260 TypeError: can't access property "getInterface", requestor is null 3 PdfStreamConverter.jsm:140:13
>     getDOMWindow resource://pdf.js/PdfStreamConverter.jsm:140
>     onStopRequest resource://pdf.js/PdfStreamConverter.jsm:1262

This seems to be because the `attachment.contentType` is empty for *new* attachments instead of `application/pdf` when it is read here https://searchfox.org/comm-central/rev/7be97df3877fcaef928606b01d455b2b49d8e9ab/mail/components/compose/content/MsgComposeCommands.js#7610). After this, the error is the same as Bug 1698140.

Note that if a message is saved and reopened for editing, any saved pdf attachments will open fine, but any newly added attachments are missing their `contentType`. ~~I think the missing `contentType` is probably a recent regression, since I didn't notice this when reviewing this patch.~~

Back to Bug 1734428 Comment 22