1734428 - PDF attachments are not opened in a tab when composing email, even though "Preview in Thunderbird" is selected as the action for PDFs

Status: VERIFIED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Alistair Cunningham]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:93.0) Gecko/20100101 Firefox/93.0

Steps to reproduce:

In Thunderbird 91, when you receive an email with an attachment, such as a .pdf file, and you click on the attachment, the attachment is loaded in a new tab within Thunderbird. However, if you compose a new email, attach a file, and then click on the attached file (perhaps to verify that you attached the correct file), then the attachment is loaded in Firefox. This is inconsistent and confusing; indeed the first few times I clicked on an attachment after upgrading to Thunderbird 91, I thought that the attachment wasn't loading at all because I didn't know to check my Firefox window.

Expected results:

Thunderbird should load attachments that are clicked on in the compose window in a new tab within Thunderbird.

Comment 1

[WaltS48 [:walts48]]

Is this with the message composition window still open, or the message saved as a draft?

Comment 2

[WaltS48 [:walts48]]

I just tested this with Thunderbird 91.1.0 from Fedora on Fedora 34.

With the mail composition window open, I am required to use right-click > Open on the PDF attachment, but it doesn't open in my Firefox or anywhere.

An attached .png file can be single clicked on to open it in my Image Viewer app.

With the message saved as a draft, the PDF attachment opens in the Thunderbird PDF Viewer tab.

Comment 3

[Alistair Cunningham]

This is with the compose email window still open.

Comment 4

[Alistair Cunningham]

By the way, "atachments" in the updated title should be spelt "attachments".

Comment 5

[Alistair Cunningham]

I've updated the title.

Comment 6

[WaltS48 [:walts48]]

Okay, I don't know what changed on my system since yesterday, but when I tested it again today using 91.1.0 from Fedora on Fedora 34 the PDF attachment in the composition window opened in my default Firefox Nightly application.

You want it to use the built-in PDF viewer.

I'm not sure whether this is a defect or an enhancement request, but I'll confirm it.

Comment 7

[Henry Wilkes (they/them) [:henry-x]]

Could this be from bug 1698140? Because pdf attachments are treated as HTML files instead.

Comment 8

[Magnus Melin [:mkmelin]]

Attachment: Bug 1734428 - handle open pdf attachment during composition using pdf.js if wanted. r=henry

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/194fce1c19d8
handle open pdf attachment during composition using pdf.js if wanted. r=henry

Comment 11

[WaltS48 [:walts48]]

Updated on Windows 10 to build 20211017105130.
Started composing a message.
Added a PDF attachment.
Double-clicked on it to open it and was asked what application I wanted to use.
Cancelled that dialog, saved the message as a draft and checked that my Daily was set to use the built-in PDF viewer, which it was, but I clicked the Action drop-down to see what other choices there were. Left it at the "Preview in Daily" action and closed the Settings tab.
Tried opening the attachment again, and it opened in the PDF Viewer tab.

Tested with a second message, and it appears I need to save the message as a draft, then open with Edit, before Thunderbird will open it in the viewer tab. Otherwise, I am asked what application I want to use if I just have the composition window open.

Comment 13

[Magnus Melin [:mkmelin]]

Comment on attachment 9245693 [details]
Bug 1734428 - handle open pdf attachment during composition using pdf.js if wanted. r=henry

[Approval Request Comment]
Regression caused by (bug #): pdf.js for tb
User impact if declined: problem opening pdfs from compose
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): low

Comment 14

[Wayne Mery (:wsmwk)]

Comment on attachment 9245693 [details]
Bug 1734428 - handle open pdf attachment during composition using pdf.js if wanted. r=henry

[Triage Comment]
Approved for beta

Comment 16

[Rob Lemley [:rjl]]

Thunderbird 94.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/6619ba3deb40

Comment 17

[efagent]

(In reply to Rob Lemley [:rjl] from comment #16)

Thunderbird 94.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/6619ba3deb40

Forgive me for being stupid but how do I get this ?
I checked and only see 94.0b4, when will this be available?
Thank you.

Comment 18

[WaltS48 [:walts48]]

(In reply to efagent from comment #17)

(In reply to Rob Lemley [:rjl] from comment #16)

Thunderbird 94.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/6619ba3deb40

Forgive me for being stupid but how do I get this ?
I checked and only see 94.0b4, when will this be available?
Thank you.

Probably sometime this week after the awesome release candidate testing team tests and approves it.

Comment 19

[efagent]

(In reply to WaltS48 [:walts48] from comment #18)

(In reply to efagent from comment #17)

(In reply to Rob Lemley [:rjl] from comment #16)

Thunderbird 94.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/6619ba3deb40

Forgive me for being stupid but how do I get this ?
I checked and only see 94.0b4, when will this be available?
Thank you.

Probably sometime this week after the awesome release candidate testing team tests and approves it.

Thank you, I'll just keep checking back. You are awesome for taking the time to respond!

Comment 20

[WaltS48 [:walts48]]

In my testing of the 94.0b5 release candidate on Windows 10, attempting to open the PDF attachment in the composition window gave me the what should Thunderbird do with this file prompt.

Testing on Linux, the attachment still opens in Firefox.

Both have "Preview in Thunderbird" as the Action in Preferences.

Comment 21

[WaltS48 [:walts48]]

Error Console messages from 94.0b5:

17:17:29.906 TypeError: requestor is null PdfStreamConverter.jsm:140:13
getDOMWindow resource://pdf.js/PdfStreamConverter.jsm:140
onStopRequest resource://pdf.js/PdfStreamConverter.jsm:1262

From 95.0a1, where the PDF wants to be saved:

17:01:48.260 TypeError: can't access property "getInterface", requestor is null 3 PdfStreamConverter.jsm:140:13
getDOMWindow resource://pdf.js/PdfStreamConverter.jsm:140
onStopRequest resource://pdf.js/PdfStreamConverter.jsm:1262

Comment 22

[Henry Wilkes (they/them) [:henry-x]]

(In reply to WaltS48 [:walts48] from comment #21)

Error Console messages from 94.0b5:

17:17:29.906 TypeError: requestor is null PdfStreamConverter.jsm:140:13
getDOMWindow resource://pdf.js/PdfStreamConverter.jsm:140
onStopRequest resource://pdf.js/PdfStreamConverter.jsm:1262

From 95.0a1, where the PDF wants to be saved:

17:01:48.260 TypeError: can't access property "getInterface", requestor is null 3 PdfStreamConverter.jsm:140:13
getDOMWindow resource://pdf.js/PdfStreamConverter.jsm:140
onStopRequest resource://pdf.js/PdfStreamConverter.jsm:1262

This seems to be because the attachment.contentType is empty for new attachments instead of application/pdf when it is read here https://searchfox.org/comm-central/rev/7be97df3877fcaef928606b01d455b2b49d8e9ab/mail/components/compose/content/MsgComposeCommands.js#7610). After this, the error is the same as Bug 1698140.

Note that if a message is saved and reopened for editing, any saved pdf attachments will open fine, but any newly added attachments are missing their contentType. I think the missing contentType is probably a recent regression, since I didn't notice this when reviewing this patch.

Comment 23

[Henry Wilkes (they/them) [:henry-x]]

I'm changing the title to distinguish this from bug 1698140 (this is for PDF attachments that should be opened internally in Thunderbird, and the other bug is for PDF attachments being treated as a HTML when they are opened externally).

This title change is a bit verbose, but I couldn't think of a better one.

Comment 24

[Henry Wilkes (they/them) [:henry-x]]

(In reply to Henry Wilkes [:henry] from comment #22)

Note that if a message is saved and reopened for editing, any saved pdf attachments will open fine, but any newly added attachments are missing their contentType. I think the missing contentType is probably a recent regression, since I didn't notice this when reviewing this patch.

Just tested in 91.2, and similarly new attachments have no contentType. So I guess I only tested on reopening drafts ...

This kind of makes sense since the file's content is not read until it is saved/sent, so its contentType will not yet be determined.

Comment 25

[Magnus Melin [:mkmelin]]

Attachment: Bug 1734428 - take2 - handle opening pdf attachments using pdf.js during composing email. r=henry

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/047ea135a09c
take2 - handle opening pdf attachments using pdf.js during composing email. r=henry

Comment 27

[WaltS48 [:walts48]]

Verified fixed in testing the 95.0b1 release candidate on Windows 10.

Comment 28

[Magnus Melin [:mkmelin]]

Comment on attachment 9248426 [details]
Bug 1734428 - take2 - handle opening pdf attachments using pdf.js during composing email. r=henry

[Approval Request Comment]
Uplift for both patches.

Comment 30

[Wayne Mery (:wsmwk)]

Comment on attachment 9248426 [details]
Bug 1734428 - take2 - handle opening pdf attachments using pdf.js during composing email. r=henry

[Triage Comment]
Approved for esr91

Comment 31

[Rob Lemley [:rjl]]

Thunderbird 91.3.1:
https://hg.mozilla.org/releases/comm-esr91/rev/42ba83eea3e4
https://hg.mozilla.org/releases/comm-esr91/rev/b591bbdc0544

Comment 32

[WaltS48 [:walts48]]

Also verified testing the 91.3.1 rc on Windows 10.

Comment 33

[BOB]

I just upgraded to 91.3.1 from 91.3.0 and when composing an email I still can't open an attached PDF file to confirm I am sending the correct attachment. I thought I read that acknowledged bug was fixed in 91.3.1 ?

Error message is: C:\Users\BOB MAIN\Documents\BELMOON-RPT-1.PDF could not be opened, because the associated helper application does not exist. Change the association in your preferences.

Thank you.

Comment 34

[WaltS48 [:walts48]]

(In reply to BOB from comment #33)

I just upgraded to 91.3.1 from 91.3.0 and when composing an email I still can't open an attached PDF file to confirm I am sending the correct attachment. I thought I read that acknowledged bug was fixed in 91.3.1 ?

Error message is: C:\Users\BOB MAIN\Documents\BELMOON-RPT-1.PDF could not be opened, because the associated helper application does not exist. Change the association in your preferences.

Thank you.

Your helper application is "Preview in Thunderbird" for "Portable Document Type (PDF)"?

That is what this bug report is about, and verified again using the 91.3.1 release on Windows 10 and Fedora Linux.

Your issue is bug 1698140.