Bug 1754314 Comment 18 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
> Also, at this time, we have not implemented this feature at all for MSIX builds (that's https://bugzilla.mozilla.org/show_bug.cgi?id=1758770, which or may not get fixed sometime soon). When wo do them, we should make sure that nothing is offered to that population of users (because it will either fail or do nothing). [`Services.sysinfo.getProperty("hasWinPackageId")` will be true](https://searchfox.org/mozilla-central/rev/5b2d2863bd315f232a3f769f76e0eb16cdca7cb0/browser/base/content/aboutDialog.js#100) for anyone running an MSIX build.

@bhearsum quick clarification doesAppNeedPin(true) inside ShellService recognize MSIX build and return false as private browsing pinning is not supported for MSIX builds Thanks

https://searchfox.org/mozilla-central/rev/0069a0cdc3cd136ea7411521219df6665f260be7/browser/components/shell/ShellService.jsm#405
Revision 1 by
on 
> Also, at this time, we have not implemented this feature at all for MSIX builds (that's https://bugzilla.mozilla.org/show_bug.cgi?id=1758770, which or may not get fixed sometime soon). When wo do them, we should make sure that nothing is offered to that population of users (because it will either fail or do nothing). [`Services.sysinfo.getProperty("hasWinPackageId")` will be true](https://searchfox.org/mozilla-central/rev/5b2d2863bd315f232a3f769f76e0eb16cdca7cb0/browser/base/content/aboutDialog.js#100) for anyone running an MSIX build.

@bhearsum quick clarification 

1) doesAppNeedPin(true) inside ShellService recognize MSIX build and return false as private browsing pinning is not supported for MSIX builds 

https://searchfox.org/mozilla-central/rev/0069a0cdc3cd136ea7411521219df6665f260be7/browser/components/shell/ShellService.jsm#405

2) Can you please share the pref  that should be flipped to enable pinning private browsing and respective bug  if there that's tracking ending that separation. Thanks
Revision 2 by
on 
> Also, at this time, we have not implemented this feature at all for MSIX builds (that's https://bugzilla.mozilla.org/show_bug.cgi?id=1758770, which or may not get fixed sometime soon). When wo do them, we should make sure that nothing is offered to that population of users (because it will either fail or do nothing). [`Services.sysinfo.getProperty("hasWinPackageId")` will be true](https://searchfox.org/mozilla-central/rev/5b2d2863bd315f232a3f769f76e0eb16cdca7cb0/browser/base/content/aboutDialog.js#100) for anyone running an MSIX build.

@bhearsum quick clarification 

1) doesAppNeedPin(true) inside ShellService recognize MSIX build and return false as private browsing pinning is not supported for MSIX builds 

https://searchfox.org/mozilla-central/rev/0069a0cdc3cd136ea7411521219df6665f260be7/browser/components/shell/ShellService.jsm#405

2) Can you please share the pref (is it just browser.privacySegmentation.enabled) that should be flipped to enable pinning private browsing and respective bug  if there that's tracking ending that separation. Thanks

Back to Bug 1754314 Comment 18