1754314 - Special message action needed for the private browsing taskbar pin

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Vtay]

For Fx100, expose a C2A for adding a taskbar shortcut to PBM on Windows through about:privatenewtab.

Comment 1

[Vtay]

The UX required would determine how much work required. For example, spotlight or CFR be the most straightforward.

Comment 2

[Ed Lee :Mardak]

Looks like the API changes have ShellService.pinToTaskbar take a privateBrowsing parameter, so maybe PIN_FIREFOX_TO_TASKBAR should take action data to pass along?

Comment 3

[Mike Kaply [:mkaply]]

We need to make sure the message to add the private browsing pin isn't shown if enterprise policy has disabled private browsing.

Comment 4

[Romain Testard [:RT]]

(In reply to Mike Kaply [:mkaply] from comment #3)

We need to make sure the message to add the private browsing pin isn't shown if enterprise policy has disabled private browsing.

Given the message happens on about:privatenewtab we should be good?

Comment 5

[Mike Kaply [:mkaply]]

Given the message happens on about:privatenewtab we should be good?

If that's the only place, then yes. Thanks!

Comment 6

[Punam Dahiya [:pdahiya]]

As per JIRA, engineering back-end work for private browsing taskbar Pin is done and can be leveraged to use as a SpecialMessageAction. NI @mardak to help scope the work needed to make API available via SpecialMessageAction to be consumed in an experiment targeting 103
https://mozilla-hub.atlassian.net/browse/OMC-193

Comment 7

[Ed Lee :Mardak]

Looks like ShellService.pinToTaskbar now takes a bool for private browsing:
https://searchfox.org/mozilla-central/rev/3419858c997f422e3e70020a46baae7f0ec6dacc/browser/components/shell/ShellService.jsm#444

So we can probably update SpecialMessageAction to pass along some action args for the existing actions (PIN_FIREFOX_TO_TASKBAR and PIN_AND_DEFAULT) or define a new action:
https://searchfox.org/mozilla-central/rev/3419858c997f422e3e70020a46baae7f0ec6dacc/toolkit/components/messaging-system/lib/SpecialMessageActions.jsm#89

Maybe related for a separate bug? But depending on how we want to target the experiment, we might need to expose users who don't already have private pinned? Although that would probably be almost all users anyway:
https://searchfox.org/mozilla-central/rev/3419858c997f422e3e70020a46baae7f0ec6dacc/browser/components/newtab/lib/ASRouterTargeting.jsm#663

Comment 8

[Punam Dahiya [:pdahiya]]

Maybe related for a separate bug? But depending on how we want to target the experiment, we might need to expose users who don't already have private pinned? Although that would probably be almost all users anyway:
https://searchfox.org/mozilla-central/rev/3419858c997f422e3e70020a46baae7f0ec6dacc/browser/components/newtab/lib/ASRouterTargeting.jsm#663

Thanks Ed , opened https://bugzilla.mozilla.org/show_bug.cgi?id=1772025, this will be needed for experiments and hiding Pin Firefox promo on about:privatebrowsing tab for users who have already pinned

Comment 9

[[e-mail] (:bhearsum)]

(In reply to Punam Dahiya [:pdahiya] from comment #6)

As per JIRA, engineering back-end work for private browsing taskbar Pin is done and can be leveraged to use as a SpecialMessageAction. NI @mardak to help scope the work needed to make API available via SpecialMessageAction to be consumed in an experiment targeting 103
https://mozilla-hub.atlassian.net/browse/OMC-193

I want to call out that we may not be ready to experiment with this in 103 for a few reasons:

• We have not localized the shortcuts yet (we're still waiting on finalized en-US strings)
• We currently have Private Browsing window separation pref'ed off, which means any windows opened through the Private Browsing taskbar icon will unexpectedly open to the regular Firefox icon. This is blocked at least on the previous item, but Product may have non-technical considerations as well.
• There's a couple of open bugs that may be serious enough to wait for before experimenting (https://bugzilla.mozilla.org/show_bug.cgi?id=1761291, https://bugzilla.mozilla.org/show_bug.cgi?id=1762994)

Feel free to reach out if I've misunderstood this or more context is needed!

Comment 10

[Punam Dahiya [:pdahiya]]

Thanks @bhearsum, will update product of possible change in experiment timelines due to dependencies listed above. As for fixes in bug 1754314, bug 1772025, I am hoping implementation can continue in parallel in Fx103 time frame even though end-to-end flow can be tested in late Fx103 or Fx104 Nightly after dependencies are resolved

Comment 11

[Punam Dahiya [:pdahiya]]

@bhearsum quick clarification on platform support for private browsing taskbar pin capability, is it Windows and Linux only or available for all platforms.

Comment 12

[[e-mail] (:bhearsum)]

(In reply to Punam Dahiya [:pdahiya] from comment #11)

@bhearsum quick clarification on platform support for private browsing taskbar pin capability, is it Windows and Linux only or available for all platforms.

It's just Windows. (That doc was written before Linux was declared as out of scope.)

Comment 13

[Meg Viar [:mviar]]

Attachment: Bug 1754314 - Special message action needed for the private browsing taskbar pin

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/788bf1f7a3f3
Special message action needed for the private browsing taskbar pin r=emcminn,barret

Comment 15

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/788bf1f7a3f3

Comment 16

[Vtay]

(In reply to [e-mail] (:bhearsum) from comment #9)

(In reply to Punam Dahiya [:pdahiya] from comment #6)

As per JIRA, engineering back-end work for private browsing taskbar Pin is done and can be leveraged to use as a SpecialMessageAction. NI @mardak to help scope the work needed to make API available via SpecialMessageAction to be consumed in an experiment targeting 103
https://mozilla-hub.atlassian.net/browse/OMC-193

I want to call out that we may not be ready to experiment with this in 103 for a few reasons:

• We have not localized the shortcuts yet (we're still waiting on finalized en-US strings)
• We currently have Private Browsing window separation pref'ed off, which means any windows opened through the Private Browsing taskbar icon will unexpectedly open to the regular Firefox icon. This is blocked at least on the previous item, but Product may have non-technical considerations as well.
• There's a couple of open bugs that may be serious enough to wait for before experimenting (https://bugzilla.mozilla.org/show_bug.cgi?id=1761291, https://bugzilla.mozilla.org/show_bug.cgi?id=1762994)

Feel free to reach out if I've misunderstood this or more context is needed!

Hi @bhearsum,
We are following up on the following on the items you have listed - do you have a status update and when do you think they might be ready?

Comment 17

[[e-mail] (:bhearsum)]

(In reply to Venetia from comment #16)

(In reply to [e-mail] (:bhearsum) from comment #9)

(In reply to Punam Dahiya [:pdahiya] from comment #6)

As per JIRA, engineering back-end work for private browsing taskbar Pin is done and can be leveraged to use as a SpecialMessageAction. NI @mardak to help scope the work needed to make API available via SpecialMessageAction to be consumed in an experiment targeting 103
https://mozilla-hub.atlassian.net/browse/OMC-193

I want to call out that we may not be ready to experiment with this in 103 for a few reasons:

• We have not localized the shortcuts yet (we're still waiting on finalized en-US strings)
• We currently have Private Browsing window separation pref'ed off, which means any windows opened through the Private Browsing taskbar icon will unexpectedly open to the regular Firefox icon. This is blocked at least on the previous item, but Product may have non-technical considerations as well.
• There's a couple of open bugs that may be serious enough to wait for before experimenting (https://bugzilla.mozilla.org/show_bug.cgi?id=1761291, https://bugzilla.mozilla.org/show_bug.cgi?id=1762994)

Feel free to reach out if I've misunderstood this or more context is needed!

Hi @bhearsum,
We are following up on the following on the items you have listed - do you have a status update and when do you think they might be ready?

Things are progressing nicely. Strings and icons have been finalized, and most of the bugs are fixed. At this point I would consider https://bugzilla.mozilla.org/show_bug.cgi?id=1761291 and pref'ing Private window separation on as blockers -- although I think we should check with Product before anything user facing is done.

Also, at this time, we have not implemented this feature at all for MSIX builds (that's https://bugzilla.mozilla.org/show_bug.cgi?id=1758770, which or may not get fixed sometime soon). When wo do them, we should make sure that nothing is offered to that population of users (because it will either fail or do nothing). Services.sysinfo.getProperty("hasWinPackageId") will be true for anyone running an MSIX build.

Comment 18

[Punam Dahiya [:pdahiya]]

Also, at this time, we have not implemented this feature at all for MSIX builds (that's https://bugzilla.mozilla.org/show_bug.cgi?id=1758770, which or may not get fixed sometime soon). When wo do them, we should make sure that nothing is offered to that population of users (because it will either fail or do nothing). Services.sysinfo.getProperty("hasWinPackageId") will be true for anyone running an MSIX build.

@bhearsum quick clarification

1. doesAppNeedPin(true) inside ShellService recognize MSIX build and return false as private browsing pinning is not supported for MSIX builds

https://searchfox.org/mozilla-central/rev/0069a0cdc3cd136ea7411521219df6665f260be7/browser/components/shell/ShellService.jsm#405

2. Can you please share the pref (is it just browser.privacySegmentation.enabled) that should be flipped to enable pinning private browsing and respective bug if there that's tracking ending that separation. Thanks

Comment 19

[[e-mail] (:bhearsum)]

(In reply to Punam Dahiya [:pdahiya] from comment #18)

Also, at this time, we have not implemented this feature at all for MSIX builds (that's https://bugzilla.mozilla.org/show_bug.cgi?id=1758770, which or may not get fixed sometime soon). When wo do them, we should make sure that nothing is offered to that population of users (because it will either fail or do nothing). Services.sysinfo.getProperty("hasWinPackageId") will be true for anyone running an MSIX build.

@bhearsum quick clarification

1. doesAppNeedPin(true) inside ShellService recognize MSIX build and return false as private browsing pinning is not supported for MSIX builds

https://searchfox.org/mozilla-central/rev/0069a0cdc3cd136ea7411521219df6665f260be7/browser/components/shell/ShellService.jsm#405

This currently returns true for MSIX, but that's a bug. I'm fixing that lie in https://bugzilla.mozilla.org/show_bug.cgi?id=1712628, and may also follow-up there in 105 or 106 with an actual implementation for MSIX.

2. Can you please share the pref (is it just browser.privacySegmentation.enabled) that should be flipped to enable pinning private browsing and respective bug if there that's tracking ending that separation. Thanks

It's just browser.privacySegmentation.enabled.

Comment 20

[Simona Rosu [:srosu], Ecosystem QA]

I‘ve verified this enhancement using the latest Firefox Nightly 104.0a1 (Build ID: 20220630212430) and Firefox Beta 103.0b3 (Build ID: 20220630185738) on Windows 10 x64.

• The Firefox PBM is pinned to taskbar after clicking the "Modify" button if the primary button contains “data”: {“privatePin”: true }.