Bug 1762081 Comment 2 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Emilio Cobos Álvarez (:emilio) from comment #1)
> https://phabricator.services.mozilla.com/D140376 is probably the cause. Now we only change the content-area and such if the theme explicitly opts into it...

Thanks for the info, indeed that's what caused the issue.

> This was an explicit UX decision because UX found confusing that changing themes like colorways would change website color schemes. Not a fan of that decision but alas.

Not a fan indeed.
It might make sense for websites, but for us it doesn't at all since we need to have a consistent UI mode, no matter if it's chrome or content,and we used to have bug reports from users having inconsistent outcomes with some tabs in dark mode and some tabs in light mode.

> We can bring something like that back if you want. It seems you just want `browser.theme.content-theme` to always be `browser.theme.toolbar-theme`.

That would be great!
(In reply to Emilio Cobos Álvarez (:emilio) from comment #1)
> https://phabricator.services.mozilla.com/D140376 is probably the cause. Now we only change the content-area and such if the theme explicitly opts into it...

Thanks for the info, indeed that's what caused the issue.

> This was an explicit UX decision because UX found confusing that changing themes like colorways would change website color schemes. Not a fan of that decision but alas.

Not a fan indeed.
It might make sense for websites, but for us it doesn't at all since we need to have a consistent UI mode, no matter if it's chrome or content, and we used to have bug reports from users having inconsistent outcomes with some tabs in dark mode and some tabs in light mode.

> We can bring something like that back if you want. It seems you just want `browser.theme.content-theme` to always be `browser.theme.toolbar-theme`.

That would be great!

Back to Bug 1762081 Comment 2