1762081 - In Content tabs like Settings, Add-ons, Account Setup, etc, are not affected by themes with dark toolbar

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect, P1)

Description

[Alessandro Castellani [:aleca]]

I don't know when this changes, probably after bug 1750932, but before if a theme was used that caused the main toolbar to have a dark background, the whole UI would change and follow the dark variation.

Now, if a theme uses a dark toolbar, only the chrome UI (mail tab, chat, compose header, etc) changes to a dark variation.
In content tabs (settings, account setup, add-ons, etc) remain with a light/default theme.

Since we don't want to implement the in content override like Firefox did in the settings (https://bugzilla.mozilla.org/attachment.cgi?id=9268292), we need to fix this.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

https://phabricator.services.mozilla.com/D140376 is probably the cause. Now we only change the content-area and such if the theme explicitly opts into it...

This was an explicit UX decision because UX found confusing that changing themes like colorways would change website color schemes. Not a fan of that decision but alas.

We can bring something like that back if you want. It seems you just want browser.theme.content-theme to always be browser.theme.toolbar-theme.

Comment 2

[Alessandro Castellani [:aleca]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #1)

https://phabricator.services.mozilla.com/D140376 is probably the cause. Now we only change the content-area and such if the theme explicitly opts into it...

Thanks for the info, indeed that's what caused the issue.

This was an explicit UX decision because UX found confusing that changing themes like colorways would change website color schemes. Not a fan of that decision but alas.

Not a fan indeed.
It might make sense for websites, but for us it doesn't at all since we need to have a consistent UI mode, no matter if it's chrome or content, and we used to have bug reports from users having inconsistent outcomes with some tabs in dark mode and some tabs in light mode.

We can bring something like that back if you want. It seems you just want browser.theme.content-theme to always be browser.theme.toolbar-theme.

That would be great!

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1762081 - Add a hidden pref to default to a unified chrome/content color-scheme. r=dao,Gijs

Thunderbird wants this. I could put the check in C++ instead, but this
is simple enough IMO.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f0a353eec89
Add a hidden pref to default to a unified chrome/content color-scheme. r=Gijs

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/6f0a353eec89

Comment 6

[Richard Marti (:Paenglab)]

Attachment: Bug 1762081 - Set the pref to use the theme color scheme on in-content pages. r=aleca

Comment 7

[Ray Fambro]

(In reply to Pulsebot from comment #4)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f0a353eec89
Add a hidden pref to default to a unified chrome/content color-scheme. r=Gijs

Thanks for providing the pref Emilio! And appreciate the feedback here as well Alessandro. Have you had a chance to test out the new Web appearance settings in about:preferences? Curious to understand if this solves the issue appropriately.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

(In reply to Ray Fambro from comment #7)

Thanks for providing the pref Emilio! And appreciate the feedback here as well Alessandro. Have you had a chance to test out the new Web appearance settings in about:preferences? Curious to understand if this solves the issue appropriately.

Thunderbird doesn't use Firefox's about:preferences page.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/380abee93610
Set the pref to use the theme color scheme on in-content pages. r=aleca