Bug 1771737 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

In bug 1771650 we're fixing some brokenness in the markup for video control errors. We should have caught the brokenness in automated tests (I mean, also in linting, for which see bug 1768884), but we didn't - I'm guessing we don't have tests that check `errorGeneric` and/or that it displays with the right string (or at least, non-empty text content once fluent has run). We should add automated tests, as this could also break in other ways.
In bug 1771650 we're fixing some brokenness in the markup for video control errors. We should have caught the brokenness in automated tests (I mean, also in linting, for which see bug 1768884), but we didn't - I'm guessing we don't have tests that check `errorGeneric` and/or that it displays with the right string (or at least, non-empty text content once fluent has run). We should add automated tests, as this could also break in other ways that wouldn't necessarily be caught by a linter.

Back to Bug 1771737 Comment 0