(In reply to Rob Wu [:robwu] from comment #2) > Is it possible to fix this by supporting `add_setup` in mochitest-plain? If someone wants to write the patch, sure. `add_task` in mochitest plain is implemented in https://searchfox.org/mozilla-central/rev/435c4ec4fb9d5b6fe491103f56969492a0038bb6/testing/mochitest/tests/SimpleTest/SimpleTest.js#2030-2036 and we'd need a similar-but-not-the-same thing for add_setup so you'd probably need to do a bunch of refactoring. When I implemented `add_setup` and realized the `add_task` implementation was not shared between xpcshell, mochitest plain/chrome and mochitest-browser, I asked if there was demand for plain/chrome `add_setup` support and got lukewarm-at-best responses in #developers on matrix, so I didn't bother attempting to write support as the mochitest-plain implementation seemed... hairy.
Bug 1776589 Comment 3 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Rob Wu [:robwu] from comment #2) > Is it possible to fix this by supporting `add_setup` in mochitest-plain? If someone wants to write the patch, sure. `add_task` in mochitest plain is implemented in https://searchfox.org/mozilla-central/rev/435c4ec4fb9d5b6fe491103f56969492a0038bb6/testing/mochitest/tests/SimpleTest/SimpleTest.js#2030-2036 and we'd need a similar-but-not-the-same thing for add_setup so you'd probably need to do a bunch of refactoring. When I implemented `add_setup` and realized the `add_task` implementation was not shared between xpcshell, mochitest plain/chrome and mochitest-browser, I asked if there was demand for plain/chrome `add_setup` support and got lukewarm-at-best responses in #developers on matrix, so I didn't bother attempting to write support as the mochitest-plain implementation seemed... hairy, and I basically never have to deal with mochitest-plain.
(In reply to Rob Wu [:robwu] from comment #2) > Is it possible to fix this by supporting `add_setup` in mochitest-plain? If someone wants to write the patch, sure. `add_task` in mochitest plain is implemented in https://searchfox.org/mozilla-central/rev/435c4ec4fb9d5b6fe491103f56969492a0038bb6/testing/mochitest/tests/SimpleTest/SimpleTest.js#2030-2036 and we'd need a similar-but-not-the-same thing for add_setup so you'd probably need to do a bunch of refactoring. When I implemented `add_setup` and realized the `add_task` implementation was not shared between xpcshell, mochitest plain/chrome and mochitest-browser, I asked if there was demand for plain/chrome `add_setup` support and got lukewarm-at-best responses in #developers on matrix, so I didn't bother attempting to write support as the mochitest-plain implementation seemed... hairy, and I basically never have to deal with mochitest-plain myself (and most new DOM/layout/whatever tests also end up using wpt, not mochitest).