1776589 - add_setup doesn't work in mochitest-plain, but eslint complains about it for mochitest-plain/chrome tests that mistakenly get browser-style test eslint rules applied to it

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Comment 1

[Mark Banner (:standard8)]

The rule is only enabled for where the browser-chrome test configuration is enabled: https://searchfox.org/mozilla-central/rev/bf6f194694c9d1ae92847f3d4e4c15c2486f3200/tools/lint/eslint/eslint-plugin-mozilla/lib/configs/browser-test.js#65

I suspect this is one of the directories where there are different types of tests in the same directory, which makes it really hard for ESLint to distinguish.

We would either need to split the test directory so that the different types of tests are in different sub-directories, or fix bug 1379669.

Comment 2

[Rob Wu [:robwu]]

Is it possible to fix this by supporting add_setup in mochitest-plain?

Comment 3

[:Gijs (he/him)]

(In reply to Rob Wu [:robwu] from comment #2)

Is it possible to fix this by supporting add_setup in mochitest-plain?

If someone wants to write the patch, sure. add_task in mochitest plain is implemented in https://searchfox.org/mozilla-central/rev/435c4ec4fb9d5b6fe491103f56969492a0038bb6/testing/mochitest/tests/SimpleTest/SimpleTest.js#2030-2036 and we'd need a similar-but-not-the-same thing for add_setup so you'd probably need to do a bunch of refactoring.

When I implemented add_setup and realized the add_task implementation was not shared between xpcshell, mochitest plain/chrome and mochitest-browser, I asked if there was demand for plain/chrome add_setup support and got lukewarm-at-best responses in #developers on matrix, so I didn't bother attempting to write support as the mochitest-plain implementation seemed... hairy, and I basically never have to deal with mochitest-plain myself (and most new DOM/layout/whatever tests also end up using wpt, not mochitest).

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:ahal, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[Sergey Galich [:serg]]

Attachment: Bug 1776589 - add add_setup to mochitest-plain r=ahal!

Comment 6

[Sergey Galich [:serg]]

Attachment: Bug 1776589 - use add_setup() in browser/extensions/formautofill r=dimi!

Depends on D153504

Comment 7

[Sergey Galich [:serg]]

Attachment: WIP: Bug 1776589 - use add_setup in dom/fs/test/mochitest "dom-storage-reviewers"

Depends on D153504

Comment 8

[Sergey Galich [:serg]]

Attachment: Bug 1776589 - use add_setup in dom/fs/test/mochitest r=#dom-storage

Depends on D153504

Comment 9

[Sergey Galich [:serg]]

Attachment: Bug 1776589 - use add_setup() in browser/components/aboutlogins r=dimi!

Depends on D153504

Comment 10

[Sergey Galich [:serg]]

Attachment: Bug 1776589 - use add_setup() in ./toolkit/components/passwordmgr r=dimi!

Depends on D153504

Comment 11

[Sergey Galich [:serg]]

Attachment: Bug 1776589 - use add_setup in form manager r=dimi!

Depends on D153504

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d984655d9fff
add add_setup to  mochitest-plain r=ahal
https://hg.mozilla.org/integration/autoland/rev/ae7ac848f06d
use add_setup() in ./toolkit/components/passwordmgr r=dimi

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ddff5dcfb118
use add_setup() in browser/components/aboutlogins r=dimi

Comment 14

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/d984655d9fff
https://hg.mozilla.org/mozilla-central/rev/ae7ac848f06d
https://hg.mozilla.org/mozilla-central/rev/ddff5dcfb118

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0006685a130f
use add_setup in form manager r=dimi

Comment 16

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/0006685a130f

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f018139e892
use add_setup() in browser/extensions/formautofill r=dimi

Comment 18

[bszekely]

https://hg.mozilla.org/mozilla-central/rev/5f018139e892

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b3410187cec3
use add_setup in dom/fs/test/mochitest r=dom-storage-reviewers,edenchuang

Comment 20

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/b3410187cec3