Bug 1778438 Comment 4 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
(In reply to Tom Schuster [:evilpie] from comment #3)
> I feel like it would be better to just wrap the whole block in `MaybeSanitizeException` with `JS_IsExceptionPending`. We should already be doing a similar check in other places.

I started to try this, but IIUC I am not supposed to include `vm/JSContext.h` inside `ExportHelpers.cpp` (needed to access `cx->isExceptionPending()`) ?
Revision 1 by
on 
(In reply to Tom Schuster [:evilpie] from comment #3)
> I feel like it would be better to just wrap the whole block in `MaybeSanitizeException` with `JS_IsExceptionPending`. We should already be doing a similar check in other places.

I started to try this, but IIUC I am not supposed to include `vm/JSContext.h` inside `ExportHelpers.cpp` (needed to access `cx->isExceptionPending()`) ?

Edit: Wait, you are hinting me to `JS_IsExceptionPending` ...

Back to Bug 1778438 Comment 4