1778438 - Do not assert for an uncatchable exception in MaybeSanitizeException

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P3)

Description

[Jens Stutte [:jstutte]]

JS::GetPendingExceptionStack is currently asserting if we have an uncatchable exception.

From MaybeSanitizeException it seems that instead we must tolerate an uncatchable exception.

Comment 1

[Jens Stutte [:jstutte]]

Note: We came here through the investigations for bug 1777198, where canceling the JS execution causes an uncatchable exception.

Comment 2

[Jens Stutte [:jstutte]]

Attachment: Bug 1778438 - Do not assert for an uncatchable exception in MaybeSanitizeException r?sfink,mccr8

Comment 3

[Tom S [:evilpie]]

I feel like it would be better to just wrap the whole block in MaybeSanitizeException with JS_IsExceptionPending. We should already be doing a similar check in other places.

Comment 4

[Jens Stutte [:jstutte]]

(In reply to Tom Schuster [:evilpie] from comment #3)

I feel like it would be better to just wrap the whole block in MaybeSanitizeException with JS_IsExceptionPending. We should already be doing a similar check in other places.

I started to try this, but IIUC I am not supposed to include vm/JSContext.h inside ExportHelpers.cpp (needed to access cx->isExceptionPending()) ?

Edit: Wait, you are hinting me to JS_IsExceptionPending ...

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c1337d82456
Do not assert for an uncatchable exception in MaybeSanitizeException r=sfink

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/5c1337d82456