Closed Bug 1778438 Opened 2 years ago Closed 2 years ago

Do not assert for an uncatchable exception in MaybeSanitizeException

Categories

(Core :: JavaScript Engine, defect, P3)

defect

Tracking

()

RESOLVED FIXED
104 Branch
Tracking Status
firefox104 --- fixed

People

(Reporter: jstutte, Assigned: jstutte)

References

Details

Attachments

(1 file)

JS::GetPendingExceptionStack is currently asserting if we have an uncatchable exception.

From MaybeSanitizeException it seems that instead we must tolerate an uncatchable exception.

Severity: -- → S4
Priority: -- → P3

Note: We came here through the investigations for bug 1777198, where canceling the JS execution causes an uncatchable exception.

See Also: → 1777198
Assignee: nobody → jstutte
Status: NEW → ASSIGNED

I feel like it would be better to just wrap the whole block in MaybeSanitizeException with JS_IsExceptionPending. We should already be doing a similar check in other places.

Summary: Do not assert for an uncatchable exception in JS::GetPendingExceptionStack → Do not assert for an uncatchable exception in MaybeSanitizeException
Attachment #9284460 - Attachment description: Bug 1778438 - Do not assert for an uncatchable exception in JS::GetPendingExceptionStack r?sfink,mccr8 → Bug 1778438 - Do not assert for an uncatchable exception in MaybeSanitizeException r?sfink,mccr8
Pushed by jstutte@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5c1337d82456
Do not assert for an uncatchable exception in MaybeSanitizeException r=sfink
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: