Bug 1782583 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Mobile devices in sync has the `deviceType` value `"mobile"` (see [here](https://searchfox.org/mozilla-central/rev/c2a2bf5a49626d63c4c0a5be42b6a93838c1b595/services/sync/modules/constants.js#130) but the class name used in the CSS is `.phone` because the `clientType` getter transforms it. The mock at https://searchfox.org/mozilla-central/rev/c2a2bf5a49626d63c4c0a5be42b6a93838c1b595/browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js#43 should be using `phone`, AFAICT. 

This of course isn't actually important because it isn't super noticeable because the test is fast, but I like using tests to get the relevant UI up on the screen quickly by pausing the test using:

```
await new Promise(resolve => setTimeout(resolve, 600000));
```

(try adding it [here](https://searchfox.org/mozilla-central/rev/c2a2bf5a49626d63c4c0a5be42b6a93838c1b595/browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js#205) to see what I mean)

I doublechecked and the icons look correct with a "real" device synced up.

But I wonder if the `mobile` vs `phone` discrepancy is what messes things up in bug 1782476.
Mobile devices in sync has the `deviceType` value `"mobile"` (see [here](https://searchfox.org/mozilla-central/rev/c2a2bf5a49626d63c4c0a5be42b6a93838c1b595/services/sync/modules/constants.js#130)) but the class name used in the CSS is `.phone` because the `clientType` getter transforms it. The mock at https://searchfox.org/mozilla-central/rev/c2a2bf5a49626d63c4c0a5be42b6a93838c1b595/browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js#43 should be using `phone`, AFAICT. 

This of course isn't actually important because it isn't super noticeable because the test is fast, but I like using tests to get the relevant UI up on the screen quickly by pausing the test using:

```
await new Promise(resolve => setTimeout(resolve, 600000));
```

(try adding it [here](https://searchfox.org/mozilla-central/rev/c2a2bf5a49626d63c4c0a5be42b6a93838c1b595/browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js#205) to see what I mean)

I doublechecked and the icons look correct with a "real" device synced up.

But I wonder if the `mobile` vs `phone` discrepancy is what messes things up in bug 1782476.

Back to Bug 1782583 Comment 0