1782583 - Device clientType is wrong for mobile device in Firefox View test browser_tab_pickup_list.js (causing missing icon)

Status: RESOLVED FIXED

(Firefox :: Firefox View, task, P2)

Description

[:Gijs (he/him)]

Mobile devices in sync has the deviceType value "mobile" (see here) but the class name used in the CSS is .phone because the clientType getter transforms it. The mock at https://searchfox.org/mozilla-central/rev/c2a2bf5a49626d63c4c0a5be42b6a93838c1b595/browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js#43 should be using phone, AFAICT.

This of course isn't actually important because it isn't super noticeable because the test is fast, but I like using tests to get the relevant UI up on the screen quickly by pausing the test using:

await new Promise(resolve => setTimeout(resolve, 600000));

(try adding it here to see what I mean)

I doublechecked and the icons look correct with a "real" device synced up.

But I wonder if the mobile vs phone discrepancy is what messes things up in bug 1782476.

Comment 1

[Hanna Jones [:hjones]]

Attachment: Bug 1782583 - fix clientType in synced tabs mock r=Gijs

It looks like the linked bug is caused by a different issue, but this still seemed worth fixing considering the mock data got moved to head.js and is being used in a few different test files now.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/febf722cbafe
fix clientType in synced tabs mock r=Gijs

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/febf722cbafe

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit auto_nag documentation.