Bug 1794162 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
The `SitePermsAddonProvider` should only be registered when the feature is enabled (controlled by the `dom.sitepermsaddon-provider.enabled` pref), otherwise we leak code that isn't supposed to be executed (or at least we do not expect that).

This is actually a (rather small) issue because we've got a report from a user who had the same error as described in Bug 1793365, except they didn't toggle any pref. Given Bug 1793365 is a different problem, this bug is only about avoiding the leak.
Revision 1 by
on 
The `SitePermsAddonProvider` should only be registered when the feature is enabled (controlled by the `dom.sitepermsaddon-provider.enabled` pref), otherwise we leak code that isn't supposed to be executed (or at least we do not expect that).

In a browser console without the pref mentioned above enabled:

```
for (const p of AddonManager.__AddonManagerInternal__.providers.entries()) { console.log(p[0].name); }
XPIProvider
SitePermsAddonProvider
GMPProvider
```

This is actually a (rather small) issue because we've got a report from a user who had the same error as described in Bug 1793365, except they didn't toggle any pref. Given Bug 1793365 is a different problem, this bug is only about avoiding the leak.

Back to Bug 1794162 Comment 0