1794162 - Only register `SitePermsAddonProvider` when the pref is enabled

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[William Durand [:willdurand]]

The SitePermsAddonProvider should only be registered when the feature is enabled (controlled by the dom.sitepermsaddon-provider.enabled pref), otherwise we leak code that isn't supposed to be executed (or at least we do not expect that).

In a browser console without the pref mentioned above enabled:

for (const p of AddonManager.__AddonManagerInternal__.providers.entries()) { console.log(p[0].name); }
XPIProvider
SitePermsAddonProvider
GMPProvider

This is actually a (rather small) issue because we've got a report from a user who had the same error as described in Bug 1793365, except they didn't toggle any pref. Given Bug 1793365 is a different problem, this bug is only about avoiding the leak.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1794162 - Only register `SitePermsAddonProvider` when the pref is enabled. r?willdurand!,timhuang!,nchevobbe

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e9a1155abc0
Only register `SitePermsAddonProvider` when the pref is enabled. r=nchevobbe,willdurand,timhuang

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/1e9a1155abc0