Bug 1797578 Comment 4 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Iorga Gabriel from comment #1)
> **Cookie banner panel part**
>  1)If the CookieBannerHandleMode is reject_all or reject_or_accept_all, I show the toggle. If the site has no exception, the toggle will be true.
> 
> https://user-images.githubusercontent.com/8118371/202170298-fb073c37-f876-4a7a-91d5-ebb0cbce2158.png
> 
>  2)If the CookieBannerHandleMode is disabled, the toggle and all the cookie banner section will be hidden.
> 
> https://user-images.githubusercontent.com/8118371/202171088-d413a06f-ff5e-4b60-bf33-6c9fcfb2f548.jpg
> 
> 3)If the user sets the toggle to false, I'm going to add the site to the exception list with the value MODE_DISABLED.
> 
> https://user-images.githubusercontent.com/8118371/202171869-87dec253-a4d3-441c-991e-014b7d434721.png
> 
> 4)If the site doesn't have a cookie banner and CookieBannerHandleMode is reject_all, or accept_all, I will show the section but not the toggle.
> 
> https://user-images.githubusercontent.com/8118371/202172562-08319d20-9384-428c-be70-44b939fbfffb.png

Hi Gabriel,

Few comments on UI/UX:
1) Minor, but the font size of 'Cookie Banner Reduction' looks larger than the other texts
2) In scenarios 3 and 4, the icon should be the disabled cookie icon (see here for reference: https://www.figma.com/file/o3TMGgSnpGNvA9GXb7FUu6/Auto-Cookie-Banners-(Focus)?node-id=603%3A17020&t=ZtIsvvfQUY4emBfs-1)
(In reply to Iorga Gabriel from comment #1)
> **Cookie banner panel part**
>  1)If the CookieBannerHandleMode is reject_all or reject_or_accept_all, I show the toggle. If the site has no exception, the toggle will be true.
> 
> https://user-images.githubusercontent.com/8118371/202170298-fb073c37-f876-4a7a-91d5-ebb0cbce2158.png
> 
>  2)If the CookieBannerHandleMode is disabled, the toggle and all the cookie banner section will be hidden.
> 
> https://user-images.githubusercontent.com/8118371/202171088-d413a06f-ff5e-4b60-bf33-6c9fcfb2f548.jpg
> 
> 3)If the user sets the toggle to false, I'm going to add the site to the exception list with the value MODE_DISABLED.
> 
> https://user-images.githubusercontent.com/8118371/202171869-87dec253-a4d3-441c-991e-014b7d434721.png
> 
> 4)If the site doesn't have a cookie banner and CookieBannerHandleMode is reject_all, or accept_all, I will show the section but not the toggle.
> 
> https://user-images.githubusercontent.com/8118371/202172562-08319d20-9384-428c-be70-44b939fbfffb.png

Hi Gabriel,

Few comments on UI/UX:
1) Minor, but the font size of 'Cookie Banner Reduction' looks larger than the other texts
2) In scenarios 3 and 4, the icon should be the disabled cookie icon (see here for reference: https://www.figma.com/file/o3TMGgSnpGNvA9GXb7FUu6/Auto-Cookie-Banners-(Focus)?node-id=603%3A17020&t=ZtIsvvfQUY4emBfs-1)
3) These are currently toggles - are we updating these to the chevrons in a future version?
(In reply to Iorga Gabriel from comment #1)
> **Cookie banner panel part**
>  1)If the CookieBannerHandleMode is reject_all or reject_or_accept_all, I show the toggle. If the site has no exception, the toggle will be true.
> 
> https://user-images.githubusercontent.com/8118371/202170298-fb073c37-f876-4a7a-91d5-ebb0cbce2158.png
> 
>  2)If the CookieBannerHandleMode is disabled, the toggle and all the cookie banner section will be hidden.
> 
> https://user-images.githubusercontent.com/8118371/202171088-d413a06f-ff5e-4b60-bf33-6c9fcfb2f548.jpg
> 
> 3)If the user sets the toggle to false, I'm going to add the site to the exception list with the value MODE_DISABLED.
> 
> https://user-images.githubusercontent.com/8118371/202171869-87dec253-a4d3-441c-991e-014b7d434721.png
> 
> 4)If the site doesn't have a cookie banner and CookieBannerHandleMode is reject_all, or accept_all, I will show the section but not the toggle.
> 
> https://user-images.githubusercontent.com/8118371/202172562-08319d20-9384-428c-be70-44b939fbfffb.png

Hi Gabriel,

Few comments on UI/UX:
1) Minor, but the font size of 'Cookie Banner Reduction' looks larger than the other texts
2) In scenarios 3 and 4, the icon should be the disabled cookie icon (see here for reference: https://www.figma.com/file/o3TMGgSnpGNvA9GXb7FUu6/Auto-Cookie-Banners-(Focus)?node-id=603%3A17020&t=ZtIsvvfQUY4emBfs-1)
3) This is currently the old toggle version - are we updating these to the versions with chevrons in the next iteration?

Back to Bug 1797578 Comment 4