Bugzilla

(In reply to :Gijs (he/him) from comment #9)
> Arthur, Josh and Mike from bug 1433523 are all no longer around. Tom, bit of a long shot but do you have context for what that change was supposed to achieve, given it was originally a Tor browser patch, and if the update restart was part of it?

I don't have any context.  My _guess_ is that there were two things happening:

1. Session Restore was _not_ saving anything to be restored when an update occurred
2. After an update occurred in Permanent Private Browsing mode, Session Restore went _looking_ for something to restore.

The combination of #2 and #1 meant that there was nothing to be found, nothing was restored, and about:tor was not shown (when it was expected to be.) The change made in the patch was to nullify #2: in Permanent Private Browsing mode do not go looking for something to restore.  (i.e. make `isAutomaticRestoreEnabled` return false)  This made the browser take a normal-ish startup path and about:tor was shown as expected.

Now I could be wrong about that, #1 is based on the fact that in the tor browser ticket no one is talking about "My open tabs were also restored".  Maybe they didn't test that?  

If that guess is right, it means that #1 (what this bug is about) was already happening.

I'd suggest just commenting out the patch added in Bug 1433523 and seeing if it behaves the way we want.  If so, we can talk to Tor about not regressing their original problem and/or not having this behavior in Tor Browser.

(In reply to :Gijs (he/him) from comment #9)
> Arthur, Josh and Mike from bug 1433523 are all no longer around. Tom, bit of a long shot but do you have context for what that change was supposed to achieve, given it was originally a Tor browser patch, and if the update restart was part of it?

I don't have any context.  My _guess_ is that there were two things happening:

1. Session Restore was _not_ saving anything to be restored when an update occurred
2. After an update occurred in Permanent Private Browsing mode, Session Restore went _looking_ for something to restore.

The combination of #2 and #1 meant that there was nothing to be found, nothing was restored, and about:tor was not shown (when it was expected to be.) The change made in the patch was to nullify #2: in Permanent Private Browsing mode do not go looking for something to restore.  (i.e. make `isAutomaticRestoreEnabled` return false)  This made the browser take a normal-ish startup path and about:tor was shown as expected.

If that guess is right, it means that #1 (what this bug is about) was already happening.

Now I could be wrong about that, #1 is based on the fact that in the tor browser ticket no one is talking about "My open tabs were also restored".  Maybe they didn't test that?  


I'd suggest just commenting out the patch added in Bug 1433523 and seeing if it behaves the way we want.  If so, we can talk to Tor about not regressing their original problem and/or not having this behavior in Tor Browser.