Closed Bug 1433523 Opened 4 years ago Closed 4 years ago

Disable session restore in permanent private browsing mode

Categories

(Firefox :: Session Restore, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 60
Tracking Status
firefox60 --- fixed

People

(Reporter: arthur, Assigned: arthur)

Details

(Whiteboard: [tor 18170])

Attachments

(1 file)

In Tor Browser, a patch was added to ensure that loaded startup tabs were correct. This involved making sure a one-time session restore does not occur in permanent private browsing mode.

Here is the Tor Browser patch:
https://torpat.ch/18170
Here is the original ticket:
https://trac.torproject.org/18170

We'd like to propose uplifting this patch.
This looks sensible to me, but the sessionstore folks will need to review it.
Component: Private Browsing → Session Restore
Comment on attachment 8950491 [details] [diff] [review]
0001-Bug-1433523-Disable-Session-Restore-in-Permanent-PBM.patch

Review of attachment 8950491 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like an effective change, thanks! Apology for the slight delay of review.
Attachment #8950491 - Flags: review?(mdeboer) → review+
Assignee: nobody → arthuredelstein
Status: NEW → ASSIGNED
Not at all. Thank you for the review!
Keywords: checkin-needed
Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1bd07bb7833c
Disable Session Restore in Permanent PBM. r=mikedeboer
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1bd07bb7833c
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
You need to log in before you can comment on or make changes to this bug.