1433523 - Disable session restore in permanent private browsing mode

Status: RESOLVED FIXED

(Firefox :: Session Restore, enhancement)

Description

[Arthur Edelstein [:arthur]]

In Tor Browser, a patch was added to ensure that loaded startup tabs were correct. This involved making sure a one-time session restore does not occur in permanent private browsing mode.

Here is the Tor Browser patch:
https://torpat.ch/18170
Here is the original ticket:
https://trac.torproject.org/18170

We'd like to propose uplifting this patch.

Comment 1

[Josh Matthews [:jdm]]

This looks sensible to me, but the sessionstore folks will need to review it.

Comment 2

[Arthur Edelstein [:arthur]]

Attachment: 0001-Bug-1433523-Disable-Session-Restore-in-Permanent-PBM.patch

try results: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c9642a11bca8

Comment 3

[Mike de Boer [:mikedeboer]]

Comment on attachment 8950491 [details] [diff] [review]
0001-Bug-1433523-Disable-Session-Restore-in-Permanent-PBM.patch

Review of attachment 8950491 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like an effective change, thanks! Apology for the slight delay of review.

Comment 4

[Arthur Edelstein [:arthur]]

Not at all. Thank you for the review!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1bd07bb7833c
Disable Session Restore in Permanent PBM. r=mikedeboer

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/1bd07bb7833c