Bug 1801608 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by

Manuel Bucher [:manuel]

on 2022-11-21 02:12:13 PST

`cos->AddClassFlags(nsIClassOfService::Unblocked);
` is called in Fetchpreloader. Should be done in EarlyHintPreloader as well.

https://searchfox.org/mozilla-central/rev/83b86005c6913c2062419efb8aabdf2e683aa47f/uriloader/preload/FetchPreloader.cpp#164-169
```cpp
// static
void FetchPreloader::PrioritizeAsPreload(nsIChannel* aChannel) {
  if (nsCOMPtr<nsIClassOfService> cos = do_QueryInterface(aChannel)) {
    cos->AddClassFlags(nsIClassOfService::Unblocked);
  }
}
```

Revision 1 by

Manuel Bucher [:manuel]

on 2022-11-21 02:18:59 PST

`cos->AddClassFlags(nsIClassOfService::Unblocked);
` is called in Fetchpreloader. Should be done in EarlyHintPreloader as well.

https://searchfox.org/mozilla-central/rev/83b86005c6913c2062419efb8aabdf2e683aa47f/uriloader/preload/FetchPreloader.cpp#164-169
```cpp
// static
void FetchPreloader::PrioritizeAsPreload(nsIChannel* aChannel) {
  if (nsCOMPtr<nsIClassOfService> cos = do_QueryInterface(aChannel)) {
    cos->AddClassFlags(nsIClassOfService::Unblocked);
  }
}
```
Also:
https://searchfox.org/mozilla-central/rev/83b86005c6913c2062419efb8aabdf2e683aa47f/uriloader/preload/PreloaderBase.cpp#118-123
```cpp
// static
void PreloaderBase::AddLoadBackgroundFlag(nsIChannel* aChannel) {
  nsLoadFlags loadFlags;
  aChannel->GetLoadFlags(&loadFlags);
  aChannel->SetLoadFlags(loadFlags | nsIRequest::LOAD_BACKGROUND);
}
```