1801608 - Priorize early hint preload as preload

Status: RESOLVED FIXED

(Core :: Networking: HTTP, task, P2)

Description

[Manuel Bucher [:manuel]]

cos->AddClassFlags(nsIClassOfService::Unblocked); is called in Fetchpreloader. Should be done in EarlyHintPreloader as well.

https://searchfox.org/mozilla-central/rev/83b86005c6913c2062419efb8aabdf2e683aa47f/uriloader/preload/FetchPreloader.cpp#164-169

// static
void FetchPreloader::PrioritizeAsPreload(nsIChannel* aChannel) {
  if (nsCOMPtr<nsIClassOfService> cos = do_QueryInterface(aChannel)) {
    cos->AddClassFlags(nsIClassOfService::Unblocked);
  }
}

Also:
https://searchfox.org/mozilla-central/rev/83b86005c6913c2062419efb8aabdf2e683aa47f/uriloader/preload/PreloaderBase.cpp#118-123

// static
void PreloaderBase::AddLoadBackgroundFlag(nsIChannel* aChannel) {
  nsLoadFlags loadFlags;
  aChannel->GetLoadFlags(&loadFlags);
  aChannel->SetLoadFlags(loadFlags | nsIRequest::LOAD_BACKGROUND);
}

Comment 1

[Manuel Bucher [:manuel]]

We might want to prioritize the different asset types differently?

• css > (or: ==/<) font > javascript > images?

Comment 2

[Manuel Bucher [:manuel]]

Attachment: Bug 1801608 - Early Hints: Depriorize preload channel to unblocked background load r=#necko

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/781cf9405c2a
Early Hints: Depriorize preload channel to unblocked background load r=necko-reviewers,valentin

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/781cf9405c2a