The behavior of CFRs that use the `CFRPopup` from AC has been changed and now behave according to what Jeff G said here: https://github.com/mozilla-mobile/fenix/issues/27033#issuecomment-1302363014 . Also you can check it in the first video I attached. The remaining problem here is the private browsing recommendation popup window, which is not using our CFRPopup composable, instead it is using the Android Popup Window widget (https://github.com/mozilla-mobile/fenix/blob/9822a2d65bdc29ec69a6918f77d229d097f39d9c/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt#L820=L860). Currently this popup: - is automatically dismissed with an outside click - is not dismissed when the screen is rotated. See second video for reference. Should this popup be modified to behave according to Jeff's steps and the first video, i.e. should it block outside touches until it is dismissed by an action from inside of it (Add to home screen/No thanks)?
Bug 1812461 Comment 5 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
The behavior of CFRs that use the `CFRPopup` from AC has been changed and now behave according to what Jeff G said here: https://github.com/mozilla-mobile/fenix/issues/27033#issuecomment-1302363014 . Also you can check it in the first video I attached. The remaining problem here is the private browsing recommendation popup window, which is not using our CFRPopup composable, instead it is using the Android Popup Window widget (https://github.com/mozilla-mobile/fenix/blob/9822a2d65bdc29ec69a6918f77d229d097f39d9c/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt#L820=L860). Currently this popup: - is automatically dismissed with an outside click - is not dismissed when the screen is rotated. See second video for reference. Currently I am working on finding a solution for this PopupWindow to behave as the CFRs do, if that won't work, a future proof solution would be to migrate it to a CFR as well.