Hi Marco, I added the "quicksuggest" result in Bug 1815699 intentionally. Sorry I wasn't explicit about it in my patch. Drew and I discussed on Slack about it and since the glean documentation links is missing "quicksuggest" it seemed to be a good opportunity for me to fix that in my patch while I'm working on weather. These docs were missing "quicksuggest": https://dictionary.telemetry.mozilla.org/apps/firefox_desktop/metrics/urlbar_impression https://dictionary.telemetry.mozilla.org/apps/firefox_desktop/metrics/urlbar_engagement/ https://dictionary.telemetry.mozilla.org/apps/firefox_desktop/metrics/urlbar_abandonment If I understand correctly, we return "quicksuggest" in glean telemetry here: UrlbarUtils.telemetryTypeFromResult https://searchfox.org/mozilla-central/rev/00ea1649b59d5f427979e2d6ba42be96f62d6e82/browser/components/urlbar/UrlbarUtils.sys.mjs#1207 We return "quicksuggest" in legacy Telemetry: https://searchfox.org/mozilla-central/rev/00ea1649b59d5f427979e2d6ba42be96f62d6e82/browser/components/urlbar/UrlbarProviderQuickSuggest.sys.mjs#532 https://searchfox.org/mozilla-central/rev/00ea1649b59d5f427979e2d6ba42be96f62d6e82/browser/components/urlbar/UrlbarProviderQuickSuggest.sys.mjs#456 Questions: Could you help me understand what you mean by > Bug 1815699 has landed some documentation changes to Metrics.yaml, but the glean event telemetry changes from that patch didn't land Does this mean my entire commit is getting backed out or was it only the `metrics.yaml` file that is getting backed out? Also, based on what I said above. Do you think I should remove "quicksuggest" in `metrics.yaml` or leave it in?
Bug 1820326 Comment 2 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Hi Marco, I added the "quicksuggest" result in Bug 1815699 intentionally. Sorry I wasn't explicit about it in my patch. Drew and I discussed on Slack about it and since the glean documentation links is missing "quicksuggest" it seemed to be a good opportunity for me to fix that in my patch while I'm working on weather. These docs were missing "quicksuggest": https://dictionary.telemetry.mozilla.org/apps/firefox_desktop/metrics/urlbar_impression https://dictionary.telemetry.mozilla.org/apps/firefox_desktop/metrics/urlbar_engagement/ https://dictionary.telemetry.mozilla.org/apps/firefox_desktop/metrics/urlbar_abandonment If I understand correctly, we return "quicksuggest" in glean telemetry here: UrlbarUtils.telemetryTypeFromResult https://searchfox.org/mozilla-central/rev/00ea1649b59d5f427979e2d6ba42be96f62d6e82/browser/components/urlbar/UrlbarUtils.sys.mjs#1207 We return "quicksuggest" in legacy Telemetry: https://searchfox.org/mozilla-central/rev/00ea1649b59d5f427979e2d6ba42be96f62d6e82/browser/components/urlbar/UrlbarProviderQuickSuggest.sys.mjs#532 https://searchfox.org/mozilla-central/rev/00ea1649b59d5f427979e2d6ba42be96f62d6e82/browser/components/urlbar/UrlbarProviderQuickSuggest.sys.mjs#456 Questions: Could you help me understand what you mean by that patch didn't land? > Bug 1815699 has landed some documentation changes to Metrics.yaml, but the glean event telemetry changes from that patch didn't land Does this mean my entire commit is getting backed out or was it only the `metrics.yaml` file that is getting backed out? Also, based on what I said above. Do you think I should remove "quicksuggest" in `metrics.yaml` or leave it in?