Closed Bug 1815699 Opened 1 year ago Closed 1 year ago

Modify relevant Telemetry probes to account for weather as a suggestion

Categories

(Firefox :: Address Bar, task, P2)

task

Tracking

()

VERIFIED FIXED
112 Branch
Tracking Status
firefox112 --- verified
firefox113 --- verified

People

(Reporter: mcheang, Assigned: mcheang)

References

Details

(Whiteboard: [snt])

Attachments

(2 files)

No description provided.

modify existing impression and engagement probes to include weather suggestion.

Attachment #9316616 - Attachment description: WIP: - Bug 1815699 - Add new weather telemetry probe for url.picked.weather and → Bug 1815699 - Modify existing Glean telemetry and add new telemetry to account for weather as a suggestion. r=adw

This patch modifies existing Glean urlbar abandonment, engagement, and
impression events by including a weather suggestion.

This patch also adds a new telemetry scalar url.picked.weather to the legacy
telemetry system.

Hi Megan,

I'm requesting a data review for the new telemetry I'm adding and existing telemetry I'm modifying for weather suggestion.

This is my first time putting up a request for data review. Please let me know if you have any questions or if you need more information from me.

Thank you for your help.

Attachment #9318579 - Flags: data-review?(mmccorquodale)

Comment on attachment 9318579 [details]
data-review-request-for-bug-1815699.md

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
    Yes, this will be documented in the Glean dictionary.

  2. Is there a control mechanism that allows the user to turn the data collection on and off?
    Yes, users can opt out of telemetry collection.

  3. If the request is for permanent data collection, is there someone who will monitor the data over time?
    This will be monitored by the search and suggest team.

  4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
    Category 2, interaction data.

  5. Is the data collection request for default-on or default-off?
    Default on.

  6. Does the instrumentation include the addition of any new identifiers?
    No new identifiers.

  7. Is the data collection covered by the existing Firefox privacy notice?
    Yes.

  8. Does the data collection use a third-party collection tool?
    No.


data-review +

Attachment #9318579 - Flags: data-review?(mmccorquodale) → data-review+
Pushed by mcheang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ccc05e5bf8b2
Modify existing Glean telemetry and add new telemetry to account for weather as a suggestion. r=adw
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
Regressions: 1820326

I have verified this issue on Firefox Beta 112 RC (Build ID: 20230403163424) and the latest Nightly 113.0a1 (Build ID: 20230404134922) on Windows 10 x64, macOS 12.6.1 and Linux Ubuntu 20.04 x64.

  • The url.picked.weather scalar is generated when clicking the weather result from the Address Bar results.
  • The weather string is added to the results and selected_result groups, depending on the type of event: urlbar impression, engagement or abandonment.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: