Bug 1820881 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
I'm happy to mentor work towards this bug. Please don't ask to be assigned to it, though you can say you're working on it. You'll be automatically assigned when you upload the first patches.

Here's what to do:

* Make sure you have a local build of Firefox up and running. Use these [instructions if you haven't already](https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html).
  * If you need help setting up, ask in [#introduction on Matrix](https://wiki.mozilla.org/Matrix)
* Using the [ESMification walkthrough](https://docs.google.com/document/d/1cpzIK-BdP7u6RJSar-Z955GV--2Rj8V4x2vl34m36Go/edit#heading=h.nu35uut81rxb) as a guide:
  1. Run `./mach esmify --convert path/to/files`
  1. Examine the output for any errors from ESLint and fix them.
  1. Next convert the imports - `./mach esmify --import . --prefix path/to/files`
  1. Again, check for any errors and fix them.
  1. Commit the changes with a commit messages such as "Bug nnnnnn - Convert path/to/files to ES modules. r?Standard8"
* Run a build to check it passes.
* Use `moz-phab submit` to submit the patch for review.
Revision 1 by
on 
I'm happy to mentor work towards this bug. Please don't ask to be assigned to it, though you can say you're working on it. You'll be automatically assigned when you upload the first patches.

Here's what to do:

* Make sure you have a local build of Firefox up and running. Use these [instructions if you haven't already](https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html).
  * If you need help setting up, ask in [#introduction on Matrix](https://wiki.mozilla.org/Matrix)
* Using the [ESMification walkthrough](https://docs.google.com/document/d/1cpzIK-BdP7u6RJSar-Z955GV--2Rj8V4x2vl34m36Go/edit#heading=h.nu35uut81rxb) as a guide:
  1. Run `./mach esmify --convert path/to/files`
  1. Examine the output for any errors from ESLint and fix them.
  1. Next convert the imports - `./mach esmify --import . --prefix path/to/files`
  1. Again, check for any errors and fix them.
  1. Run a build to check it passes.
  1. Also run `./mach eslint --fix path/to/files` and check there are no raised failures
  1. Commit the changes with a commit messages such as "Bug nnnnnn - Convert path/to/files to ES modules. r?Standard8"
* Use `moz-phab submit` to submit the patch for review.
Revision 2 by
on 
I'm happy to mentor work towards this bug. Please don't ask to be assigned to it, though you can say you're working on it. You'll be automatically assigned when you upload the first patches.

Here's what to do:

* Make sure you have a local build of Firefox up and running. Use these [instructions if you haven't already](https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html).
  * If you need help setting up, ask in [#introduction on Matrix](https://wiki.mozilla.org/Matrix)
* Using the [ESMification walkthrough](https://docs.google.com/document/d/1cpzIK-BdP7u6RJSar-Z955GV--2Rj8V4x2vl34m36Go/edit#heading=h.nu35uut81rxb) as a guide:
  1. Run `./mach esmify --convert path/to/files`
  1. Examine the output for any errors from ESLint and fix them.
  1. Next convert the imports - `./mach esmify --import . --prefix path/to/files`
  1. Again, check for any errors and fix them.
  1. Run a build to check it passes.
  1. Also run `./mach eslint --fix path/to/files` and check there are no raised failures
  1. Commit the changes with a commit messages such as "Bug nnnnnn - Convert path/to/files to ES modules. r?Standard8"
* Use `moz-phab submit` to submit the patches for review.

Back to Bug 1820881 Comment 0