Closed
Bug 1820881
Opened 1 year ago
Closed 1 year ago
Convert toolkit/mozapps/handling to ES modules
Categories
(Firefox :: File Handling, task)
Firefox
File Handling
Tracking
()
RESOLVED
FIXED
112 Branch
Tracking | Status | |
---|---|---|
firefox112 | --- | fixed |
People
(Reporter: standard8, Assigned: tiwari.abhishektiwari23, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [esmification-timeline][lang=js])
Attachments
(1 file)
I'm happy to mentor work towards this bug. Please don't ask to be assigned to it, though you can say you're working on it. You'll be automatically assigned when you upload the first patches.
Here's what to do:
- Make sure you have a local build of Firefox up and running. Use these instructions if you haven't already.
- If you need help setting up, ask in #introduction on Matrix
- Using the ESMification walkthrough as a guide:
- Run
./mach esmify --convert path/to/files
- Examine the output for any errors from ESLint and fix them.
- Next convert the imports -
./mach esmify --import . --prefix path/to/files
- Again, check for any errors and fix them.
- Run a build to check it passes.
- Also run
./mach eslint --fix path/to/files
and check there are no raised failures - Commit the changes with a commit messages such as "Bug nnnnnn - Convert path/to/files to ES modules. r?Standard8"
- Run
- Use
moz-phab submit
to submit the patches for review.
Assignee | ||
Comment 1•1 year ago
|
||
I am working on the issue and will make review soon
Assignee | ||
Comment 2•1 year ago
|
||
Depends on D171992
Updated•1 year ago
|
Assignee: nobody → tiwari.abhishektiwari23
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•1 year ago
|
||
Sir, I have made a patch just by following your instructions. Please have a look and let me know. Thanks.
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/97c750ecba4d Convert toolkit/mozapps/handling to ES modules. r=Standard8
Comment 5•1 year ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox112:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•