Bug 1821296 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Currently [test_bug930456_child.js](https://searchfox.org/mozilla-central/rev/cd2121e7d83af1b421c95e8c923db70e692dab5f/toolkit/components/search/tests/xpcshell/test_bug930456_child.js) is [disabled in the xpcshell.ini file](https://searchfox.org/mozilla-central/rev/cd2121e7d83af1b421c95e8c923db70e692dab5f/toolkit/components/search/tests/xpcshell/xpcshell.ini#74-75) and doesn't run because various items in `head_search.js` require to be loaded in the main process.

Given that the search service is [explicitly defined as main process only](https://searchfox.org/mozilla-central/rev/cd2121e7d83af1b421c95e8c923db70e692dab5f/toolkit/components/search/components.conf#15), I don't think it is worth having a specific test for that. We should be able to assume that the component definition works correctly, and if it was changed in the future, changing the component definition should be fairly obvious that it'd need checking. 

Additionally, I don't think we do these types of tests in other places.

Hence, I think we should simply remove both `test_bug930456_child.js` and test_bug930456.js` and the references to them from the `xpcshell.ini`.
Currently [test_bug930456_child.js](https://searchfox.org/mozilla-central/rev/cd2121e7d83af1b421c95e8c923db70e692dab5f/toolkit/components/search/tests/xpcshell/test_bug930456_child.js) is [disabled in the xpcshell.ini file](https://searchfox.org/mozilla-central/rev/cd2121e7d83af1b421c95e8c923db70e692dab5f/toolkit/components/search/tests/xpcshell/xpcshell.ini#74-75) and doesn't run because various items in `head_search.js` require to be loaded in the main process.

Given that the search service is [explicitly defined as main process only](https://searchfox.org/mozilla-central/rev/cd2121e7d83af1b421c95e8c923db70e692dab5f/toolkit/components/search/components.conf#15), I don't think it is worth having a specific test for that. We should be able to assume that the component definition works correctly, and if it was changed in the future, changing the component definition should be fairly obvious that it'd need checking. 

Additionally, I don't think we do these types of tests in other places.

Hence, I think we should simply remove both `test_bug930456_child.js` and `test_bug930456.js` and the references to them from the `xpcshell.ini`.

Back to Bug 1821296 Comment 0