Closed Bug 1821296 Opened 1 year ago Closed 1 year ago

Remove test_bug930456.js and test_bug930456_child.js

Categories

(Firefox :: Search, task, P3)

task

Tracking

()

RESOLVED FIXED
112 Branch
Tracking Status
firefox112 --- fixed

People

(Reporter: standard8, Assigned: osuolale49, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: [lang=js])

Attachments

(1 file)

Currently test_bug930456_child.js is disabled in the xpcshell.ini file and doesn't run because various items in head_search.js require to be loaded in the main process.

Given that the search service is explicitly defined as main process only, I don't think it is worth having a specific test for that. We should be able to assume that the component definition works correctly, and if it was changed in the future, changing the component definition should be fairly obvious that it'd need checking.

Additionally, I don't think we do these types of tests in other places.

Hence, I think we should simply remove both test_bug930456_child.js and test_bug930456.js and the references to them from the xpcshell.ini.

Hello Mark. My name is Yusuf, and i am an outreachy applicant participating for the 2023 outreachy internship program. I would like to be assigned to work on this issue. Thank you.

Thank you for the offer, you'll be automatically assigned to it when the patch is uploaded.

Assignee: nobody → osuolale49
Status: NEW → ASSIGNED
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f51c9e9c7a25
Remove test_bug930456.js and test_bug930456_child.js r=Standard8
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
You need to log in before you can comment on or make changes to this bug.