1821296 - Remove test_bug930456.js and test_bug930456_child.js

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

Currently test_bug930456_child.js is disabled in the xpcshell.ini file and doesn't run because various items in head_search.js require to be loaded in the main process.

Given that the search service is explicitly defined as main process only, I don't think it is worth having a specific test for that. We should be able to assume that the component definition works correctly, and if it was changed in the future, changing the component definition should be fairly obvious that it'd need checking.

Additionally, I don't think we do these types of tests in other places.

Hence, I think we should simply remove both test_bug930456_child.js and test_bug930456.js and the references to them from the xpcshell.ini.

Comment 1

[yusufjakada5]

Hello Mark. My name is Yusuf, and i am an outreachy applicant participating for the 2023 outreachy internship program. I would like to be assigned to work on this issue. Thank you.

Comment 2

[Mark Banner (:standard8)]

Thank you for the offer, you'll be automatically assigned to it when the patch is uploaded.

Comment 3

[Noah Osuolale]

Attachment: Bug 1821296 - Remove test_bug930456.js and test_bug930456_child.js r=standard8

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f51c9e9c7a25
Remove test_bug930456.js and test_bug930456_child.js r=Standard8

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f51c9e9c7a25