Bug 1830115 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
**Found in**
* 114.0a1 (2023-04-26)

**Affected versions**
* 114.0a1

**Tested platforms**
* Affected platforms:
         - Windows 10
         - Mac 13.2.1
 


**Preconditions**
* Have VPN connected to CA/US.
* Google as default search engine.
* browser.search.region set to CA/US
* browser.urlbar.trending.featureGate set to true


**Steps to reproduce**
1. Open address bar.
2. Type/Paste a full address like: https://www.pathofexile.com/ several times to create a bit of history.
3. Do some google, ddg searches.
4. Open a tab and pick google search mode.
5. Open a tab and pick ddg search mode.
6. Open about:config and set `browser.urlbar.trending.featureGate` to false
7. Open a tab and pick google search mode.
8. Open a tab and pick ddg search mode.

**Expected result**
4. With `browser.urlbar.update2.emptySearchBehavior` set on 2, the history and search history are displayed + trending predictions (probably influenced by https://mozilla-hub.atlassian.net/browse/SNT-443)
5. History and search history are displayed.
7. History and search history are displayed.
8. History and search history are displayed.

**Actual result**
4. With `browser.urlbar.update2.emptySearchBehavior` set on 2, the history and search history are NOT displayed - only trending predictions 
5. History and search history are NOT displayed.
7. History and search history are displayed.
8. History and search history are displayed.

**Regression range**
* Regressed by bug 1824965 feature ; will narrow it further down to the exact commit if need be at a later date

**Notes**
- Having `browser.urlbar.trending.featureGate` false reinstates functionality for non-default values of browser.urlbar.update2.emptySearchBehavior. 
- The addition of https://mozilla-hub.atlassian.net/browse/SNT-443 should account for this issue.
Revision 1 by
on 
**Found in**
* 114.0a1 (2023-04-26)

**Affected versions**
* 114.0a1

**Tested platforms**
* Affected platforms:
         - Windows 10
         - Mac 13.2.1
 


**Preconditions**
* Have VPN connected to CA/US.
* Google as default search engine.
* browser.search.region set to CA/US
* browser.urlbar.trending.featureGate set to true
* browser.urlbar.trending.requireSearchMode set to false


**Steps to reproduce**
1. Open address bar.
2. Select a google trending prediction / perform a simple search (idea is to have the persisted search term in the address bar)
3. Click the address bar.

**Expected result**
The persist search term is selected, suggestions with the persisted search term are displayed.

**Actual result**
Before the persisted search termin suggestions are displayed there is a small flicker with trending predictions

**Regression range**
* New feature interaction with persistent search.

**Notes**
- Having the persistent search feature turned off - either by pref or enabling search bar will not generate the above flicker since the trending predictions will be displayed as default on selecting the address bar -> with full url displayed.
Revision 2 by
on 
**Found in**
* 114.0a1 (2023-04-26)

**Affected versions**
* 114.0a1

**Tested platforms**
* Affected platforms:
         - Windows 10
         - Mac 13.2.1
 


**Preconditions**
* Have VPN connected to CA/US.
* Google as default search engine.
* browser.search.region set to CA/US
* browser.urlbar.trending.featureGate set to true
* browser.urlbar.trending.requireSearchMode set to false


**Steps to reproduce**
1. Open address bar.
2. Select a google trending prediction / perform a simple search (idea is to have the persisted search term in the address bar)
3. Click the address bar.

**Expected result**
The persist search term is selected, suggestions with the persisted search term are displayed.

**Actual result**
Before the persisted search termin suggestions are displayed there is a small flicker with trending predictions

**Regression range**
* New feature interaction with persistent search.

**Notes**
- Having the persistent search feature turned off - either by pref or enabling search bar will not generate the above flicker since the trending predictions will be displayed as default on selecting the address bar -> with full url displayed.
- The reload of the GTP from bug 1825751 can be also noticed in the first 3s of the attachment.
Revision 3 by
on 
**Found in**
* 114.0a1 (2023-04-26)

**Affected versions**
* 114.0a1

**Tested platforms**
* Affected platforms:
         - Windows 10
         - Mac 13.2.1
 


**Preconditions**
* Have VPN connected to CA/US.
* Google as default search engine.
* browser.search.region set to CA/US
* browser.urlbar.trending.featureGate set to true
* browser.urlbar.trending.requireSearchMode set to false


**Steps to reproduce**
1. Open address bar.
2. Select a google trending prediction / perform a simple search (idea is to have the persisted search term in the address bar)
3. Click the address bar.

**Expected result**
The persist search term is selected, suggestions with the persisted search term are displayed.

**Actual result**
Before the persisted search termin suggestions are displayed there is a small flicker with trending predictions

**Regression range**
* New feature interaction with persistent search.

**Notes**
- Having the persistent search feature turned off - either by pref or enabling search bar will not generate the above flicker since the trending predictions will be displayed as default on selecting the address bar -> with full url displayed.
- The reload of the GTP from bug 1825751 can be also noticed in the first 2s of the attachment.
Revision 4 by
on 
**Found in**
* 114.0a1 (2023-04-26)

**Affected versions**
* 114.0a1

**Tested platforms**
* Affected platforms:
         - Windows 10
         - Mac 13.2.1
 


**Preconditions**
* Have VPN connected to CA/US.
* Google as default search engine.
* browser.search.region set to CA/US
* browser.urlbar.trending.featureGate set to true
* browser.urlbar.trending.requireSearchMode set to false


**Steps to reproduce**
1. Open address bar.
2. Select a google trending prediction / perform a simple search (idea is to have the persisted search term in the address bar)
3. Click the address bar.

**Expected result**
The persist search term is selected, suggestions with the persisted search term are displayed.

**Actual result**
Before the persisted search termin suggestions are displayed there is a small flicker with trending predictions

**Regression range**
* N/A -> New feature interaction with persistent search.

**Notes**
- Having the persistent search feature turned off - either by pref or enabling search bar will not generate the above flicker since the trending predictions will be displayed as default on selecting the address bar -> with full url displayed.
- The reload of the GTP from bug 1825751 can be also noticed in the first 2s of the attachment.

Back to Bug 1830115 Comment 0