Bugzilla

In the scope of 1829334 we implemented "browser.close" command similar to "session.end" when we first return the response and then perform all the required steps for quitting the browser. This has a couple of problems: 
- first, we will not return an argument error in case there are any;
- second, if there are any failures during quitting, clients will not be notified about it.
The problem is that "browser.close" includes ending the session step, which now automatically closes the socket, so we need to return the result of the command before this step.

To solve the first problem, we can start quitting logic earlier and return the command response on "quit-application-requested" notification before ending the session.
The solution of the second problem would require most likely a bigger refactoring to unbind session clean up and closing the websocket.

In the scope of bug 1829334 we implemented "browser.close" command similar to "session.end" when we first return the response and then perform all the required steps for quitting the browser. This has a couple of problems: 
- first, we will not return an argument error in case there are any;
- second, if there are any failures during quitting, clients will not be notified about it.
The problem is that "browser.close" includes ending the session step, which now automatically closes the socket, so we need to return the result of the command before this step.

To solve the first problem, we can start quitting logic earlier and return the command response on "quit-application-requested" notification before ending the session.
The solution of the second problem would require most likely a bigger refactoring to unbind session clean up and closing the websocket.