Closed Bug 1829334 Opened 8 months ago Closed 5 months ago

Implement "browser.close" command

Categories

(Remote Protocol :: WebDriver BiDi, task, P2)

Product:
Remote Protocol
Component:
WebDriver BiDi
Type:
task
Points:
5

Tracking

(firefox117 fixed)

Status:
RESOLVED FIXED
Milestone:
117 Branch
Tracking Flags:
Tracking Status
firefox117 --- fixed

People

(Reporter: whimboo, Assigned: Sasha)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [webdriver:m8], [wptsync upstream] [webdriver:relnote])

Attachments

(4 files)

Bug 1829334 - [marionette] Move browser quit logic into shared module.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1829334 - [bidi] Implement "browser.close" command.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1829334 - [wdspec] Add browser module to bidi test client.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1829334 - [wdspec] Add gecko specific tests for browser.close command for bidi only session.
48 bytes, text/x-phabricator-request
Details | Review

This command will be pretty helpful for BiDi only clients who currently cannot shutdown the browser cleanly.

We probably want to share some code that Marionette already has to quit the browser.

Before this command can be implemented we need session.end support (bug 1829337) first.

I would vote for a late M7 inclusion.

Type: enhancement → task
Depends on: 1829337
Whiteboard: [webdriver:triage]
Points: --- → 5
Priority: -- → P2
Whiteboard: [webdriver:triage] → [webdriver:m7]
Assignee: nobody → aborovova
Status: NEW → ASSIGNED
Whiteboard: [webdriver:m7] → [webdriver:m8]
Pushed by aborovova@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/df033b47c65a
[marionette] Move browser quit logic into shared module. r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/312c493691a5
[bidi] Implement "browser.close" command. r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/45c0bbd714c0
[wdspec] Add browser module to bidi test client. r=webdriver-reviewers,jgraham,whimboo
https://hg.mozilla.org/integration/autoland/rev/c29fc6627305
[wdspec] Add gecko specific tests for browser.close command for bidi only session. r=webdriver-reviewers,whimboo
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/40915 for changes under testing/web-platform/tests
Whiteboard: [webdriver:m8] → [webdriver:m8], [wptsync upstream]
Upstream PR merged by moz-wptsync-bot
Regressions: 1842322
Whiteboard: [webdriver:m8], [wptsync upstream] → [webdriver:m8], [wptsync upstream] [webdriver:relnote]
You need to log in before you can comment on or make changes to this bug.