Bug 1847273 Comment 17 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Roger Yang [:royang] from comment #16)
> I like this idea.  But the problem here is if the user ticked "don't ask me again" we need to keep that preference permanent.

Just to clarify: I didn't intend for any sort of permanence in my comment 13 proposal. In the repeated-spammy-`alert()` situation that I'm drawing inspiration from (see my jsfiddle above), we only persist the "don't allow any more" setting for the current pageload.  So there's no preference-management/clearing UI necessary.

In a perfect world we could persist it for longer and offer UI to clear it, but maybe persisting it for the current instance would be a good improvement over what we've got right now?

That would still address bug 1830348, I think.  It could mean that a potentially mean a spammy app would regain the ability to request its app to be installed each time you navigate from one page to the next, despite the fact that the user checked the "don't ask me again" checkbox. That's admittedly confusing, but it's also arguably less confusing than the current situation where a single "cancel" prevents any further requests for an hour.  We do also have "Open links in apps: never" as an option that users could fall back on if they are really running up against that?
(In reply to Roger Yang [:royang] from comment #16)
> I like this idea.  But the problem here is if the user ticked "don't ask me again" we need to keep that preference permanent.

Just to clarify: I didn't intend for any sort of permanence in my comment 13 proposal. In the repeated-spammy-`alert()` situation that I'm drawing inspiration from (see my jsfiddle above), we only persist the "don't allow any more" setting for the current pageload.  So there's no preference-management/clearing UI necessary.

In a perfect world we could persist it for longer and offer UI to clear it, but maybe persisting it for the current pageload would be a good improvement over what we've got right now?

That would still address bug 1830348, I think.  It could mean that a potentially mean a spammy app would regain the ability to request its app to be installed each time you navigate from one page to the next, despite the fact that the user checked the "don't ask me again" checkbox. That's admittedly confusing, but it's also arguably less confusing than the current situation where a single "cancel" prevents any further requests for an hour.  We do also have "Open links in apps: never" as an option that users could fall back on if they are really running up against that?

Back to Bug 1847273 Comment 17