1830348 - Amazon Sign-in from the web breaks when Amazon Shopping app is installed

Status: RESOLVED FIXED

(Firefox for Android :: App Links, defect, P2)

Description

[Zac McKenney [:zmckenney]]

Steps to reproduce

1. Install Amazon Shopping
2. Check Fenix setting for "Open links in apps" is set to "Ask before opening"
3. Go to https://www.amazon.com in Fenix
4. Tap "Sign-In"
5. See the prompt to open the app but cancel it
6. Enter email or phone number
7. Click "Continue"
8. See the prompt to open the app but cancel it
9. Website states "We're sorry. The Web address you entered is not a functioning page on our site"

Expected behavior

Site should not break when the app is installed and the link to open it is cancelled.

Actual behavior

Only when the app is installed and the user sees the alert dialog does the amazon sign-in break.

Device information

• Firefox version: 114.0a1 (Nightly), 112.2.0 (Release)
• Android device model: Samsung Z Fold 3
• Android OS version: Android 13

Any additional information?

Video of it breaking, then switching the setting to not open links in app, and then it working.
https://drive.google.com/file/d/1HuByNIdaGyrjhYgEHcfuPcdsH8NNU8O8/view?usp=sharing

Comment 1

[Zac McKenney [:zmckenney]]

Potentially related to 1813446 since the video in that bug has a samsung dialog showing before seeing the same error page.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jonalmeida, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[Joe M [:jmahon]]

:jonalmeida for the purposes of Kanban board planning: any idea if this falls more in Foundation team or Experience team? And, would this be better suited for the Browser Engine component?

Comment 4

[Jonathan Almeida [:jonalmeida]]

I'd say for this one, Experience since royang has already picked it up. Maybe we should great a new component for App Links since the Browser Engine component is a big one?

It might be a good component for the Foundation team to triage first in general though.

Comment 5

[Roger Yang [:royang]]

With the fix for https://bugzilla.mozilla.org/show_bug.cgi?id=1836971. There is now a workaround for this. Set "Open links in apps" as "Never" before signing into Amazon. I will continue investigation on this so we have a better workaround/solution.

Comment 6

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1830348 - Use do not intercept cache in app links interceptor (#2978)

Comment 7

[BMO Github Automation]

Authored by https://github.com/rocketsroger
https://github.com/mozilla-mobile/firefox-android/commit/04295bc67168afe3514dd195a91916527a197c00
[main] Bug 1830348 - Use do not intercept cache in app links interceptor

Comment 8

[Lorand Janos]

Managed to reproduce the issue on the latest Beta build (116.0b8).
Verified as fixed on the latest Nightly build (118.0a1 from 2023-08-01).
The error is no longer when the app is installed and the link to open it is cancelled.

Devices used for testing:

• Oppo Find X5 (Android 13).
• Google Pixel 7 (Android 14).

Marking the ticket as verified.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:royang, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox117 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Roger Yang [:royang]]

Comment on attachment 9345459 [details] [review]
[mozilla-mobile/firefox-android] Bug 1830348 - Use do not intercept cache in app links interceptor (#2978)

Beta/Release Uplift Approval Request

• User impact if declined: Cannot sign into Amazon (or similar sites) even if user rejects redirect to external app.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only affects open links in app in cases where user rejects redirect to external app.
• String changes made/needed:
• Is Android affected?: Yes

Comment 11

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1830348 - Use do not intercept cache in app links interceptor (backport #2978) (#3103)

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9347189 [details] [review]
[mozilla-mobile/firefox-android] Bug 1830348 - Use do not intercept cache in app links interceptor (backport #2978) (#3103)

Approved for 117.0b3.

Comment 13

[BMO Github Automation]

Authored by https://github.com/rocketsroger
https://github.com/mozilla-mobile/firefox-android/commit/2b036d89962354f971b9e4dad2ce1143053bf614
[releases_v117] Bug 1830348 - Use do not intercept cache in app links interceptor

Comment 14

[Lorand Janos]

Verified as fixed on the latest Beta build (117.0b3).
The error is no longer displayed when the app is installed and the link to open it is cancelled.

Devices used for testing:

• Oppo Find X5 (Android 13).
• Google Pixel 7 (Android 14).

Marking the ticket as verified for 117 as well.