Bug 1847288 Comment 9 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

That sounds Great!, because yes i was not happy to have to copy most of the classes and only having modified one function in it.
im not sure ive done this in python before, but i get the idea.
In the Parameters class for example, i have only touched the `file_url(self, path, pretty=False)` function

i would do something like this?!
```
from taskgraph.parameters import Parameters
def parameters_file_url(self, path, pretty=False): # my modified function
    .....

def load_parameters_file(....):
    ....
    if not spec:
        taskgraph.parameters.Parameters.file_url = parameters_file_url
        return Parameters(strict=strict, repo_root=repo_root, **overrides)
```
That sounds Great!, because yes i was not happy to have to copy most of the classes and only having modified one function in it.
im not sure ive done this in python before, but i get the idea.
In the Parameters class for example, i have only touched the `file_url(self, path, pretty=False)` function

i would do something like this?!
```
from taskgraph.parameters import Parameters
def parameters_file_url(self, path, pretty=False): # my modified function
    .....

def load_parameters_file(....):
    ....
    if not spec:
        taskgraph.parameters.Parameters.file_url = parameters_file_url
        return Parameters(strict=strict, repo_root=repo_root, **overrides)
```
---- edit ----
nevermind, i think you ment to recreate the PR to taskgraph into monkey patched functions here.
will look more into that and get back with a Needinfo when i have something.

Back to Bug 1847288 Comment 9