Bug 1847599 Comment 6 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
The old pref names (layout.css.font-visibility.private etc.) still exist in the tree in one spot, in nimbus/FeatureManifest.yaml , here:
https://searchfox.org/mozilla-central/rev/7fe1954b761abeff36122b4a6ac74619704ee787/toolkit/components/nimbus/FeatureManifest.yaml#1432-1448
```
fontvisibility:
  description: Control Font Visibility in PBM
  owner: tom@mozilla.com
  hasExposure: false
  variables:
    enabledETP:
      type: int
      setPref: layout.css.font-visibility.trackingprotection
      description: Set the Font Visibility level when Enhanced Tracking Protection is enabled
    enabledStandard:
      type: int
      setPref: layout.css.font-visibility.standard
      description: Set the Font Visibility level for normal browsing
    enabledPBM:
      type: int
      setPref: layout.css.font-visibility.private
      description: Set the Font Visibility level for private browsing (will override ETP)
```

Maybe worth removing that in a followup? Presumably we don't want to be toggling those prefs via Nimbus anymore, if they're non-functional.
Revision 1 by
on 
The old pref names (layout.css.font-visibility.private etc.) still exist in the tree in one spot, in nimbus/FeatureManifest.yaml , here:
https://searchfox.org/mozilla-central/rev/7fe1954b761abeff36122b4a6ac74619704ee787/toolkit/components/nimbus/FeatureManifest.yaml#1432-1448
```
fontvisibility:
  description: Control Font Visibility in PBM
  owner: tom@mozilla.com
  hasExposure: false
  variables:
    enabledETP:
      type: int
      setPref: layout.css.font-visibility.trackingprotection
      description: Set the Font Visibility level when Enhanced Tracking Protection is enabled
    enabledStandard:
      type: int
      setPref: layout.css.font-visibility.standard
      description: Set the Font Visibility level for normal browsing
    enabledPBM:
      type: int
      setPref: layout.css.font-visibility.private
      description: Set the Font Visibility level for private browsing (will override ETP)
```

Maybe worth removing that in a followup? Presumably we don't want to be toggling those prefs via Nimbus anymore, if they've been simplified away (and are non-functional using those old names).

Back to Bug 1847599 Comment 6