1847599 - Clean up Font Visibility Prefs and RFPTargets

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, enhancement)

Description

[Tom Ritter [:tjr]]

This is not well documented and very confusing.

Comment 1

[Tom Ritter [:tjr]]

Attachment: Bug 1847599: Simplify Font Visibility rules r?jfkthame,timhuang

This patch removes the separate Font Visbility pref for ETP and the
logic that makes the effective level for PBMode the lesser of PBM
and Standard mode. We do not need these levels of granularity,
they are confusing.

Fix the problem where the ETP Toggle would override the RFP Pref -
that should not occur, the ETP Toggle doesn't override that.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f29e7cc4d688
Simplify Font Visibility rules r=jfkthame,timhuang

Comment 3

[Norisz Fay [:noriszfay]]

Backed out for causing bustages on nsPresContext.cpp

Backout link

Push with failures

Failure log

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb06ef97c8af
Simplify Font Visibility rules r=jfkthame,timhuang

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/eb06ef97c8af

Comment 6

[Daniel Holbert [:dholbert]]

The old pref names (layout.css.font-visibility.private etc.) still exist in the tree in one spot, in nimbus/FeatureManifest.yaml , here:
https://searchfox.org/mozilla-central/rev/7fe1954b761abeff36122b4a6ac74619704ee787/toolkit/components/nimbus/FeatureManifest.yaml#1432-1448

fontvisibility:
  description: Control Font Visibility in PBM
  owner: [e-mail]
  hasExposure: false
  variables:
    enabledETP:
      type: int
      setPref: layout.css.font-visibility.trackingprotection
      description: Set the Font Visibility level when Enhanced Tracking Protection is enabled
    enabledStandard:
      type: int
      setPref: layout.css.font-visibility.standard
      description: Set the Font Visibility level for normal browsing
    enabledPBM:
      type: int
      setPref: layout.css.font-visibility.private
      description: Set the Font Visibility level for private browsing (will override ETP)

Maybe worth removing that in a followup? Presumably we don't want to be toggling those prefs via Nimbus anymore, if they've been simplified away (and are non-functional using those old names).