This happens because the upgrade spotlight opening the wizard from this aboutwelcome-bundle message uses `browser.migrate.content-modal.about-welcome-behavior` changed in bug 1839431. This spotlight is shown on top of `about:home` which is considered a "blank" page safe to be replaced by about:preferences, and a similar issue was fixed for opening the about:preferences content-modal from about:welcome in bug 1826920. The screens missed from replacing about:home with about:preferences: mobile download, pin private, gratitude https://searchfox.org/mozilla-central/rev/f1f50693655c093d974f026bd37860d939cd5529/browser/components/newtab/lib/OnboardingMessageProvider.jsm#281,326,427 As suggested in comment 0, there's potentially a few possible fixes: 1. use embedded for upgrade spotlight 2. keep about:home open and open about:preferences in separate tab 3. keep using legacy wizard The first might have some complications for how data gets in/out of the spotlight context but is probably what we want long term anyway. The second probably is tricky as about:home probably does want to be replaced when opening preferences from the page's sidebar but not when the spotlight is open. The third could be a bit hacky by changing the pref to "legacy" as users getting the upgrade spotlight shouldn't be seeing about:welcome.
Bug 1848973 Comment 1 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
This happens because the upgrade spotlight opening the wizard from this aboutwelcome-bundle message uses `browser.migrate.content-modal.about-welcome-behavior` changed in bug 1839431. This spotlight is shown on top of `about:home` which is considered a "blank" page safe to be replaced by about:preferences, and a similar issue was fixed for opening the about:preferences content-modal from about:welcome in bug 1826920. The screens missed from replacing about:home with about:preferences: mobile download, pin private, gratitude https://searchfox.org/mozilla-central/rev/f1f50693655c093d974f026bd37860d939cd5529/browser/components/newtab/lib/OnboardingMessageProvider.jsm#281,326,427 As suggested in comment 0, there's potentially a few possible fixes: 1. use embedded for upgrade spotlight 2. keep about:home open and open about:preferences in separate tab 3. keep using legacy wizard The first might have some ~complications for how data gets in/out of the spotlight context~ (fixed bug 1837051) but is probably what we want long term anyway. The second probably is tricky as about:home probably does want to be replaced when opening preferences from the page's sidebar but not when the spotlight is open. The third could be a bit hacky by changing the pref to "legacy" as users getting the upgrade spotlight shouldn't be seeing about:welcome.