1848973 - The Onboarding modal for upgrading users is dismissed if the "Import from previous browser" button from the "Import Data" screen is clicked

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue.gif

[Notes]:

• Considering that in Firefox 117 we turned on by default the “Embedded Import Wizard” in the "about:welcome" page, the QA opinion is that we should do the same for the "Import Data" upgrading users modal in order to avoid dismissing the whole upgrading users Oboarding flow.

[Affected versions]:

• Firefox Release 117.0b8 - Build ID: 20230815180041
• Firefox Nightly 118.0a1 - Build ID: 20230816094547

[Affected Platforms]:

• Windows 10 x64
• macOS 13.4.1
• Ubuntu 22.04 x64

[Prerequisites]:

• Have a Firefox Beta version older or equal to 116 installed.

[Steps to reproduce]:

1. Open the browser with the profile from the prerequisites.
2. Upgrade the browser to the latest version.
3. Navigate through the Onboarding flow for the upgrading users until the "Import Data" modal is displayed.
4. Click the "Import from previous browser" button and observe the behavior.

[Expected result]:

• The Embedded Import Wizard is opened and the Onboarding modal is not dismissed.
  OR
• The Import Wizard from the "about:preferences" page is opened a new tab and the Onboarding modal is not dismissed.

[Actual result]:

• Client is redirected in the same tab to the "about:preferences" page and the Onboarding modal for upgrading users is dismissed.

[Additional Notes]:

• This issue is not reproducible on Firefox 116.0.2 because on this version the “legacy” version of the Import Wizard is still the default one.
• If the “about:preferences#general” page is already opened in a separate tab, that tab will be focused and the Onboarding modal for upgrading users is not dismissed.
• Attached is a screen recording of the issue:

@Ed could you please take a look over this behavior? We are unsure if the Onboarding flow for existing users will be displayed in Firefox 117 after a browser update.

Comment 1

[Ed Lee :Mardak]

This happens because the upgrade spotlight opening the wizard from this aboutwelcome-bundle message uses browser.migrate.content-modal.about-welcome-behavior changed in bug 1839431. This spotlight is shown on top of about:home which is considered a "blank" page safe to be replaced by about:preferences, and a similar issue was fixed for opening the about:preferences content-modal from about:welcome in bug 1826920.

The screens missed from replacing about:home with about:preferences: mobile download, pin private, gratitude
https://searchfox.org/mozilla-central/rev/f1f50693655c093d974f026bd37860d939cd5529/browser/components/newtab/lib/OnboardingMessageProvider.jsm#281,326,427

As suggested in comment 0, there's potentially a few possible fixes:

1. use embedded for upgrade spotlight
2. keep about:home open and open about:preferences in separate tab
3. keep using legacy wizard

The first might have some complications for how data gets in/out of the spotlight context (fixed bug 1837051) but is probably what we want long term anyway. The second probably is tricky as about:home probably does want to be replaced when opening preferences from the page's sidebar but not when the spotlight is open. The third could be a bit hacky by changing the pref to "legacy" as users getting the upgrade spotlight shouldn't be seeing about:welcome.

Comment 2

[Ed Lee :Mardak]

Fortunately with bug 1837051 fixed in 116, the fix to use embedded in upgrade spotlight should hopefully be straightforward.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1839431

:nsauermann, since you are the author of the regressor, bug 1839431, could you take a look?

For more information, please visit BugBot documentation.

Comment 4

[Ed Lee :Mardak]

[Tracking Requested - why for this release]: Users upgrading and clicking import miss out on the rest of the upgrade spotlight onboarding.

Comment 5

[Negin]

Attachment: Bug 1848973 - Fixes upgrade dialog dismissing after import by adding embedded import

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/536bc940d00d
Fixes upgrade dialog dismissing after import by adding embedded import r=omc-reviewers,Mardak

Comment 7

[Negin]

Comment on attachment 9349245 [details]
Bug 1848973 - Fixes upgrade dialog dismissing after import by adding embedded import

Beta/Release Uplift Approval Request

• User impact if declined: Users upgrading and who click import miss out on the rest of the upgrade spotlight onboarding flow (mobile download, pin private, gratitude screens).
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Steps can be found in the test plan in Phabricator or in the QA reproduction steps from the bug description.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Embedded import wizard feature has been QA'd previously for about:welcome flow and Spotlight integration has been QA'd as well and is covered by integration tests.
• String changes made/needed: N/A
• Is Android affected?: No

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/536bc940d00d

Comment 9

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible using the latest Firefox Nightly 118.0a1 (Build ID: 20230816215210) installed on Windows 10 x64, macOS 13.4.1, and Linux Mint 21.1. I can confirm the following:

• The Upgrade dialog is no longer dismissed after the "Import from previous browser" button is clicked.
• The "Embedded Import Wizard" is opened.
• The import process is completed successfully.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9349245 [details]
Bug 1848973 - Fixes upgrade dialog dismissing after import by adding embedded import

Approved for 117.0b9.

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/ff0cc5da5df5

Comment 12

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible using the latest Firefox Beta 117.0b9 (Build ID: 20230817175856) installed on Windows 10 x64, macOS 13.4.1, and Linux Mint 21.1. I can confirm the following:

• The Upgrade dialog is no longer dismissed after the "Import from previous browser" button is clicked.
• The "Embedded Import Wizard" is opened.
• The import process is completed successfully.