Bug 1849354 Comment 4 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Rares Doghi, Desktop QA from comment #0)
> **Expected result**
> * The user should not be able to zoom in and out of the Sidebar.

FWIW, to whoever fixes this: we might actually want more graceful expected-results than just fully disabling zoom. The sidebar has some fine print near the bottom that's fairly small (`font-size: 0.6875em;` on the `.legal-paragraph` element[1] which works out to `11px`), which might be hard for some users to read, and they might reach for mousewheel-zoom, with the expectation that it will work.

(Admittedly, full-page-zoom has no effect on some similar bits of Firefox UI -- e.g. the bookmarks/history sidebar that appears if you do Ctrl+H / Ctrl+B -- but those also don't have 11px-sized-text that might need to be zoomed to be visible.)

So: if we do disable zoom, we need to be extra-sure that we're abiding by whatever minimum font sizes that we aim to satisfy in other unzoomable areas of our UI.

[1] https://searchfox.org/mozilla-central/rev/61aca7cda4b217245d9af5aac5bf49bf0d5ecfe3/browser/components/newtab/aboutwelcome/content/aboutwelcome.css#695
(In reply to Rares Doghi, Desktop QA from comment #0)
> **Expected result**
> * The user should not be able to zoom in and out of the Sidebar.

FWIW, to whoever fixes this: we might actually want more graceful expected-results than just fully disabling zoom. The shopping sidebar's first-run UI has some fine print near the bottom that's fairly small (`font-size: 0.6875em;` on the `.legal-paragraph` element[1] which works out to `11px`), which might be hard for some users to read, and they might reach for mousewheel-zoom, with the expectation that it will work.

(Admittedly, full-page-zoom has no effect on some similar bits of Firefox UI -- e.g. the bookmarks/history sidebar that appears if you do Ctrl+H / Ctrl+B -- but those also don't have 11px-sized-text that might need to be zoomed to be visible.)

So: if we do disable zoom, we need to be extra-sure that we're abiding by whatever minimum font sizes that we aim to satisfy in other unzoomable areas of our UI.

[1] https://searchfox.org/mozilla-central/rev/61aca7cda4b217245d9af5aac5bf49bf0d5ecfe3/browser/components/newtab/aboutwelcome/content/aboutwelcome.css#695
(In reply to Rares Doghi, Desktop QA from comment #0)
> **Expected result**
> * The user should not be able to zoom in and out of the Sidebar.

FWIW, to whoever fixes this: we might actually want more graceful expected-results than just fully disabling zoom. The shopping sidebar's first-run UI has some fine print near the bottom (`By selecting “Yes, try it“ you agree to [etc]`) which is fairly small (`font-size: 0.6875em;` on the `.legal-paragraph` element[1] which works out to `11px`), which might be hard for some users to read, and they might reach for mousewheel-zoom, with the expectation that it will work.

(Admittedly, full-page-zoom has no effect on some similar bits of Firefox UI -- e.g. the bookmarks/history sidebar that appears if you do Ctrl+H / Ctrl+B -- but those also don't have 11px-sized-text that might need to be zoomed to be visible.)

So: if we do disable zoom, we need to be extra-sure that we're abiding by whatever minimum font sizes that we aim to satisfy in other unzoomable areas of our UI.

[1] https://searchfox.org/mozilla-central/rev/61aca7cda4b217245d9af5aac5bf49bf0d5ecfe3/browser/components/newtab/aboutwelcome/content/aboutwelcome.css#695
(In reply to Rares Doghi, Desktop QA from comment #0)
> **Expected result**
> * The user should not be able to zoom in and out of the Sidebar.

FWIW, to whoever fixes this: we might actually want more graceful expected-results than just fully disabling zoom. The shopping sidebar's first-run UI has some fine print near the bottom (`By selecting “Yes, try it“ you agree to [etc]`) which is fairly small (`font-size: 0.6875em;` on the `.legal-paragraph` element[1] -- devtools says this works out to `11px`).  That text is important and might be hard for some users to read, and they might reach for mousewheel-zoom, with the expectation that it will work.

(Admittedly, full-page-zoom has no effect on some similar bits of Firefox UI -- e.g. the bookmarks/history sidebar that appears if you do Ctrl+H / Ctrl+B -- but those also don't have 11px-sized-text that might need to be zoomed to be visible.)

So: if we do disable zoom, we need to be extra-sure that we're abiding by whatever minimum font sizes that we aim to satisfy in other unzoomable areas of our UI.

[1] https://searchfox.org/mozilla-central/rev/61aca7cda4b217245d9af5aac5bf49bf0d5ecfe3/browser/components/newtab/aboutwelcome/content/aboutwelcome.css#695

Back to Bug 1849354 Comment 4