1849354 - The Fakespot shopping sidebar can be Zoomed in/out

Status: NEW

(Firefox :: Shopping, defect, P3)

Description

[Rares Doghi, Desktop QA]

Found in

• Nightly 118.0a1 (2023-08-18)

Affected versions

• Nightly 118.0a1 (2023-08-18)

Affected platforms

• ALL

Preconditions:
Set the browser.shopping.experience2023.enabled - TRUE
browser.shopping.experience2023.optedIn - 1
Set the toolkit.shopping.useOHTTP - TRUE

Steps to reproduce

1. Reach about:preferences and turn off feature recommendations.
2. Reach the Amazon https://www.amazon.com/dp/B09B6ZXD2V/ref=sbl_dpx_office-desks_B0B4CYW8FB_0 link
3. Use Pinch Zoom or Ctrl+mouse wheel in order to zoom in and out of the Shopping sidebar.

Expected result

• The user should not be able to zoom in and out of the Sidebar.

Actual result

• The Fakespot shopping sidebar can be zoomed in and out.

Regression range
Not Applicable

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:rdoghi, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Jonathan Epstein]

Fast-follow after MVP

Comment 4

[Daniel Holbert [:dholbert]]

(In reply to Rares Doghi, Desktop QA from comment #0)

Expected result

• The user should not be able to zoom in and out of the Sidebar.

FWIW, to whoever fixes this: we might actually want more graceful expected-results than just fully disabling zoom. The shopping sidebar's first-run UI has some fine print near the bottom (By selecting “Yes, try it“ you agree to [etc]) which is fairly small (font-size: 0.6875em; on the .legal-paragraph element[1] -- devtools says this works out to 11px). That text is important and might be hard for some users to read, and they might reach for mousewheel-zoom, with the expectation that it will work.

(Admittedly, full-page-zoom has no effect on some similar bits of Firefox UI -- e.g. the bookmarks/history sidebar that appears if you do Ctrl+H / Ctrl+B -- but those also don't have 11px-sized-text that might need to be zoomed to be visible.)

So: if we do disable zoom, we need to be extra-sure that we're abiding by whatever minimum font sizes that we aim to satisfy in other unzoomable areas of our UI.

[1] https://searchfox.org/mozilla-central/rev/61aca7cda4b217245d9af5aac5bf49bf0d5ecfe3/browser/components/newtab/aboutwelcome/content/aboutwelcome.css#695

Comment 5

[Anna Yeddi [:ayeddi]]

Since both blocking zooming and allowing zoom that cuts off/overflows the content have accessibility implications especially for users with low vision, adding an access keyword and marking it up as access-s3 for now, because the current implementation does cut off some content when pinch-zoomed or browser zoomed on Windows.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S4. However, the accessibility severity is higher, .
:jhirsch, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 7

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Moving "fast follow" items to top-level in the shopping backlog. Apologies for bug spam