Bug 1858978 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

**Notes**
* While investigating this issue, we figured that for the same search terms queries spread across different engines have the same moz_historyform id, which in turn doesn’t allow deleting and will trigger a not so recent search term pop-up while using a different engine than the one that last_used was updated on.
* To our assessment, this issue and its implications, although it is a S3 from the browser perspective, it can be considered S1/S2 from the feature perspective.

**Found in**
* Nightly 120.0a1;

**Affected versions**
* Nightly 120.0a1;

**Tested platforms**
* Windows 10;
* Ubuntu 22;
* macOS 13; 


**Preconditions**
* browser.urlbar.recentsearches.featureGate set to true 
* browser.urlbar.suggest.recentsearches set to true 

**Steps to reproduce**
1. Launch Firefox with the profile from preconditions.
2. Focus the Address Bar and perform some searches(1,2,3,4,5) using the default search engine(A).
3. Change the default search engine and perform the same search using the new default engine(B) (1,2,3,4,5).
4. Open a new tab and focus the Address Bar.
5. Open the result menu and click on the ‘Remove from history’ option for the (3) of the recent search terms- recent search (3) for engineB is deleted
6. Switch back to the original search engine(A) and focus the Address Bar

**Expected result**
* Recent Search (3) is still displayed for the engine A

**Actual result**
* Recent Search (3) is still displayed for the engine A

**Regression range**
* Not a regression.
**Notes**
* While investigating this issue, we figured that for the same search terms queries spread across different engines have the same moz_historyform id, which in turn doesn’t allow deleting and will trigger a not so recent search term pop-up while using a different engine than the one that last_used was updated on.
* To our assessment, this issue and its implications, although it is a S3 from the browser perspective, it can be considered S1/S2 from the feature perspective.

**Found in**
* Nightly 120.0a1;

**Affected versions**
* Nightly 120.0a1;

**Tested platforms**
* Windows 10;
* Ubuntu 22;
* macOS 13; 


**Preconditions**
* browser.urlbar.recentsearches.featureGate set to true 
* browser.urlbar.suggest.recentsearches set to true 

**Steps to reproduce**
1. Launch Firefox with the profile from preconditions.
2. Focus the Address Bar and perform some searches(1,2,3,4,5) using the default search engine(A).
3. Change the default search engine and perform the same search using the new default engine(B) (1,2,3,4,5).
4. Open a new tab and focus the Address Bar.
5. Open the result menu and click on the ‘Remove from history’ option for the (3) of the recent search terms- recent search (3) for engineB is deleted
6. Switch back to the original search engine(A) and focus the Address Bar

**Expected result**
* Recent Search (3) is still displayed for the engine A

**Actual result**
* Recent Search (3) is still displayed for the engine A

**Regression range**
* Not a regression.

**Later Edit:**
* The Address bar original search history removal would not delete the search from browser history, although we also believe that was wrong, since user perspective doesn't necesarily differentiates betwen the search term history and the search term query string.
**Notes**
* While investigating this issue, we figured that for the same search terms queries spread across different engines have the same moz_historyform id, which in turn doesn’t allow deleting and will trigger a not so recent search term pop-up while using a different engine than the one that last_used was updated on.
* To our assessment, this issue and its implications, although it is a S3 from the browser perspective, it can be considered S1/S2 from the feature perspective.

**Found in**
* Nightly 120.0a1;

**Affected versions**
* Nightly 120.0a1;

**Tested platforms**
* Windows 10;
* Ubuntu 22;
* macOS 13; 


**Preconditions**
* browser.urlbar.recentsearches.featureGate set to true 
* browser.urlbar.suggest.recentsearches set to true 

**Steps to reproduce**
1. Launch Firefox with the profile from preconditions.
2. Focus the Address Bar and perform some searches(1,2,3,4,5) using the default search engine(A).
3. Change the default search engine and perform the same search using the new default engine(B) (1,2,3,4,5).
4. Open a new tab and focus the Address Bar.
5. Open the result menu and click on the ‘Remove from history’ option for the (3) of the recent search terms- recent search (3) for engineB is deleted
6. Switch back to the original search engine(A) and focus the Address Bar

**Expected result**
* Recent Search (3) is still displayed for the engine A

**Actual result**
* Recent Search (3) is not displayed for the engine A.

**Regression range**
* Not a regression.

**Later Edit:**
* The Address bar original search history removal would not delete the search from browser history, although we also believe that was wrong, since user perspective doesn't necesarily differentiates betwen the search term history and the search term query string.
**Notes**
* While investigating this issue, we figured that for the same search terms queries spread across different engines have the same moz_historyform id, which in turn doesn’t allow deleting and will trigger a not so recent search term pop-up while using a different engine than the one that last_used was updated on.
* To our assessment, this issue and its implications, although it is a S3 from the browser perspective, it can be considered S1/S2 from the feature perspective.

**Found in**
* Nightly 120.0a1;

**Affected versions**
* Nightly 120.0a1;

**Tested platforms**
* Windows 10;
* Ubuntu 22;
* macOS 13; 


**Preconditions**
* browser.urlbar.recentsearches.featureGate set to true 
* browser.urlbar.suggest.recentsearches set to true 

**Steps to reproduce**
1. Launch Firefox with the profile from preconditions.
2. Focus the Address Bar and perform some searches(1,2,3,4,5) using the default search engine(A).
3. Change the default search engine and perform the same search using the new default engine(B) (1,2,3,4,5).
4. Open a new tab and focus the Address Bar.
5. Open the result menu and click on the ‘Remove from history’ option for the (3) of the recent search terms- recent search (3) for engineB is deleted
6. Switch back to the original search engine(A) and focus the Address Bar

**Expected result**
* Recent Search (3) is still displayed for the engine A

**Actual result**
* Recent Search (3) is not displayed for the engine A.

**Regression range**
* Not a regression.

Back to Bug 1858978 Comment 0