1858978 - Same search terms across different engines are using the same moz_historyform

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Adrian Florinescu [:aflorinescu] [PTO until Aug 26]]]

Notes

• While investigating this issue, we figured that for the same search terms queries spread across different engines have the same moz_historyform id, which in turn doesn’t allow deleting and will trigger a not so recent search term pop-up while using a different engine than the one that last_used was updated on.
• To our assessment, this issue and its implications, although it is a S3 from the browser perspective, it can be considered S1/S2 from the feature perspective.

Found in

• Nightly 120.0a1;

Affected versions

• Nightly 120.0a1;

Tested platforms

• Windows 10;
• Ubuntu 22;
• macOS 13;

Preconditions

• browser.urlbar.recentsearches.featureGate set to true
• browser.urlbar.suggest.recentsearches set to true

Steps to reproduce

1. Launch Firefox with the profile from preconditions.
2. Focus the Address Bar and perform some searches(1,2,3,4,5) using the default search engine(A).
3. Change the default search engine and perform the same search using the new default engine(B) (1,2,3,4,5).
4. Open a new tab and focus the Address Bar.
5. Open the result menu and click on the ‘Remove from history’ option for the (3) of the recent search terms- recent search (3) for engineB is deleted
6. Switch back to the original search engine(A) and focus the Address Bar

Expected result

• Recent Search (3) is still displayed for the engine A

Actual result

• Recent Search (3) is not displayed for the engine A.

Regression range

• Not a regression.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:aflorinescu, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Dale Harvey (:daleharvey)]

Attachment: Bug 1858978 - Restrict search history deletions by engine. r=Mak

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb15479a0d0d
Restrict search history deletions by engine. r=mak

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/bb15479a0d0d

Comment 5

[Adrian Florinescu [:aflorinescu] [PTO until Aug 26]]]

Verified with 120.0a1 20231018094117 on Windows 10.

Thank you Dale for the fix. With the fix applied, deleting the recent searches works engine base, however the problem for update remains the same. Since we have a patch here, I'm going to open a followup bug - see bug 1859785.