Bug 1865685 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

macOS adds some menu items to our menu bar, such as the emoji picker. The shortcuts for these menu items may not work properly, since we do not have an internal representation of these menu items. One potential solution is to allow these menu items to execute their actions and stop the propagation of the event. This would be a departure from our current strategy where all of these events go through our `keyDown:` handler, i.e. `TextInputHandler::HandleKeyDownEvent`. I'm going to attach a patch for discussion. This patch fixes a variety of bugs, such as bug 1855346, bug 1806374 and others. It does not, however, address bug 1333781.
macOS adds some menu items to our menu bar, such as the emoji picker. The shortcuts for these menu items may not work properly, since we do not have an internal representation of these menu items. One potential solution is to allow these menu items to execute their actions and stop the propagation of the event. This would be a departure from our current strategy where all of these events go through our `keyDown:` handler, i.e. `TextInputHandler::HandleKeyDownEvent`. I'm going to attach a patch for discussion. This patch fixes a variety of bugs, such as bug 1855346, bug 1833923, bug 1806374 and others. It does not, however, address bug 1333781.

Back to Bug 1865685 Comment 0