1865685 - Consider allowing macOS-provided menu items to execute their action without propagating the event to our keyDown: handler

Status: RESOLVED WONTFIX

(Core :: Widget: Cocoa, task)

Description

[Stephen A Pohl [:spohl]]

macOS adds some menu items to our menu bar, such as the emoji picker. The shortcuts for these menu items may not work properly, since we do not have an internal representation of these menu items. One potential solution is to allow these menu items to execute their actions and stop the propagation of the event. This would be a departure from our current strategy where all of these events go through our keyDown: handler, i.e. TextInputHandler::HandleKeyDownEvent. I'm going to attach a patch for discussion. This patch fixes a variety of bugs, such as bug 1855346, bug 1833923, bug 1806374 and others. It does not, however, address bug 1333781.

Comment 1

[Stephen A Pohl [:spohl]]

Attachment: Bug 1865685: Stop propagating keyDown events if they are shortcuts for macOS-provided menu items, such as the emoji picker. r=mstange,masayuki

Comment 2

[Stephen A Pohl [:spohl]]

I'm going to abandon this bug in favor of a better patch that I will be posting to bug 1855346 to address the Ctrl+Cmd+Spacebar case. I will file a separate bug to start respecting the Fn+e shortcuts (and similar Fn shortcuts) and we will want to land both at the same time to support current and legacy shortcuts for the emoji picker and other menu items.