(In reply to Mike Conley (:mconley) (:⚙️) from comment #1) > Hi pdahiya, > > Is there a good way for me to determine which of the images in browser/components/newtab/data/content/assets could be moved under browser/components/aboutwelcome? It looks like these images are used in a variety of places - some in newtab, others by various onboarding surfaces. Or is this a matter of doing a one-by-one audit? Hi Mike, That's correct since aboutwelcome bundle is used to render UI for multiple messaging surfaces (Onboarding, spotlight, feature callout) , will recommend moving all assets used via about aboutwelcome bundle out of newtab inside `browser/components/aboutwelcome` , here's initial stab at for assets that can be moved : - Images prefixed with mr-* -mobile-download-* -long-zap -short-zap -noodle-* -person-typing - device-migration from https://searchfox.org/mozilla-central/source/browser/components/newtab/data/content/assets
Bug 1866138 Comment 2 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Mike Conley (:mconley) (:⚙️) from comment #1) > Hi pdahiya, > > Is there a good way for me to determine which of the images in browser/components/newtab/data/content/assets could be moved under browser/components/aboutwelcome? It looks like these images are used in a variety of places - some in newtab, others by various onboarding surfaces. Or is this a matter of doing a one-by-one audit? Hi Mike, That's correct since aboutwelcome bundle is used to render UI for multiple messaging surfaces (Onboarding, spotlight, feature callout) , will recommend moving all assets used via about aboutwelcome bundle out of newtab inside `browser/components/aboutwelcome` , here's initial stab at for assets that can be moved : -Images prefixed with mr-* -mobile-download-* -long-zap -short-zap -noodle-* -person-typing -device-migration from https://searchfox.org/mozilla-central/source/browser/components/newtab/data/content/assets