1866138 - Move about:welcome image assets out from browser/components/newtab into browser/components/aboutwelcome

Status: RESOLVED FIXED

(Firefox :: Messaging System, task, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

pdahiya noticed that we can move image assets specific to about:welcome out from browser/components/newtab after bug 1863400 lands. This bug is for that.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Hi pdahiya,

Is there a good way for me to determine which of the images in browser/components/newtab/data/content/assets could be moved under browser/components/aboutwelcome? It looks like these images are used in a variety of places - some in newtab, others by various onboarding surfaces. Or is this a matter of doing a one-by-one audit?

Comment 2

[Punam Dahiya [:pdahiya]]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #1)

Hi pdahiya,

Is there a good way for me to determine which of the images in browser/components/newtab/data/content/assets could be moved under browser/components/aboutwelcome? It looks like these images are used in a variety of places - some in newtab, others by various onboarding surfaces. Or is this a matter of doing a one-by-one audit?

Hi Mike, That's correct since aboutwelcome bundle is used to render UI for multiple messaging surfaces (Onboarding, spotlight, feature callout) , will recommend moving all assets used via about aboutwelcome bundle out of newtab inside browser/components/aboutwelcome , here's initial stab at for assets that can be moved :

-Images prefixed with mr-*
-mobile-download-*
-long-zap
-short-zap
-noodle-*
-person-typing
-device-migration
from https://searchfox.org/mozilla-central/source/browser/components/newtab/data/content/assets

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Okay, got it - thank you!

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Is it safe to say that, given that there are at least a few active aboutwelcome experiments, that we'd want to maintain the chrome://activity-stream/content/data/content/assets/ mapping, despite moving the images out? Or do you think it's safe to update these URLs to be prefixed like:

chrome://browser/skin/aboutwelcome/ - for example, chrome://browser/skin/aboutwelcome/person-typing.svg?

Comment 5

[Punam Dahiya [:pdahiya]]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #4)

Is it safe to say that, given that there are at least a few active aboutwelcome experiments, that we'd want to maintain the chrome://activity-stream/content/data/content/assets/ mapping, despite moving the images out? Or do you think it's safe to update these URLs to be prefixed like:

chrome://browser/skin/aboutwelcome/ - for example, chrome://browser/skin/aboutwelcome/person-typing.svg?

That's a good callout, I agree it will be good to keep assets reference same to avoid possible conflicts with live experiment/rollouts and take this prefix change with Bug 1866935

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1866138 - Move about:welcome image assets to browser/components/aboutwelcome/assets. r?pdahiya!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f8d0a90e80b
Move about:welcome image assets to browser/components/aboutwelcome/assets. r=pdahiya,desktop-theme-reviewers,dao

Comment 8

[Iulian Moraru]

Backed out for causing bc failures related to aboutwelcome and crashes with this signature [@ mozilla::net::CheckForBrokenChromeURL]

• Push with failures

• Failure log example 1

• Failure log example 2

• Failure log example 3

• Backout link

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e33b9c14dbf
Move about:welcome image assets to browser/components/aboutwelcome/assets. r=pdahiya,desktop-theme-reviewers,dao

Comment 10

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/8e33b9c14dbf