(In reply to Ed Lee :Mardak from comment #16) > (In reply to Negin from comment #14) > > discrepancy between Nightly and Beta (unless there are no language packs compatible with nightly?) > > Oh, that's a good point. I don't think langpacks are normally available on nightly unless you specially set some prefs. Bug 1849882 adding additional effect dependencies means the effect can run much more often than previously configured potentially resulting in multiple `languageFilteredScreens` changes? Yeah that's my guess! I re-introduced each reverted dependency since logging them out didn't reveal anything. Re-introducing `screenIndex` dependency is the only one causing re-renders but when I log out the value it's 1 so that's a bit odd https://searchfox.org/mozilla-central/source/browser/components/aboutwelcome/content-src/components/LanguageSwitcher.jsx#142
Bug 1873019 Comment 17 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Ed Lee :Mardak from comment #16) > (In reply to Negin from comment #14) > > discrepancy between Nightly and Beta (unless there are no language packs compatible with nightly?) > > Oh, that's a good point. I don't think langpacks are normally available on nightly unless you specially set some prefs. Bug 1849882 adding additional effect dependencies means the effect can run much more often than previously configured potentially resulting in multiple `languageFilteredScreens` changes? Yeah that's my guess! I re-introduced each reverted dependency since logging them out didn't reveal anything. Re-introducing `screenIndex` dependency is the only one causing re-renders but when I log out the value it's 1 so that's a bit odd https://searchfox.org/mozilla-central/source/browser/components/aboutwelcome/content-src/components/LanguageSwitcher.jsx#142 `setScreenIndex(screenIndex - 1)` should mean that it's not creating a new object so I'm not sure what exactly is causing it to re-compute?
(In reply to Ed Lee :Mardak from comment #16) > (In reply to Negin from comment #14) > > discrepancy between Nightly and Beta (unless there are no language packs compatible with nightly?) > > Oh, that's a good point. I don't think langpacks are normally available on nightly unless you specially set some prefs. Bug 1849882 adding additional effect dependencies means the effect can run much more often than previously configured potentially resulting in multiple `languageFilteredScreens` changes? Yeah that's my guess! I re-introduced each reverted dependency since logging them out didn't reveal anything. Re-introducing `screenIndex` dependency is the only one causing infinite re-renders but when I log out the value it's 1 so that's a bit odd https://searchfox.org/mozilla-central/source/browser/components/aboutwelcome/content-src/components/LanguageSwitcher.jsx#142 `setScreenIndex(screenIndex - 1)` should mean that it's not creating a new object so I'm not sure what exactly is causing it to re-compute?